From: "Jörn Engel" <joern@logfs.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: "Jörn Engel" <joern@logfs.org>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block2mtd lockdep_init_map warning
Date: Sun, 6 Jan 2008 22:25:42 +0100 [thread overview]
Message-ID: <20080106212542.GA5262@lazybastard.org> (raw)
In-Reply-To: <200801061911.m06JBldW020012@agora.fsl.cs.sunysb.edu>
On Sun, 6 January 2008 14:11:47 -0500, Erez Zadok wrote:
>
> The problem appears to be an interaction of two components--module loading
> and lockdep--that's perhaps why it wasn't given enough attention.
Correct. For modules lockdep depends on initializations done after
module_init has finished. However block2mtd is an odd sod that can call
into lockdep code during module_init, causing the bug you noticed.
Several solutions are possible. Modules could get two initcalls, one to
decide whether module load should get aborted, the other run later,
after the remaining module initializations are done. Or the module
loader could always do the initializations and revoke them later, if
module_init failed.
But I personally am too unfamiliar with the module code to trust my
judgement and have yet to receive feedback. Even you seem to ignore my
mails and not even Cc: me later on. I must have done something really
horrible in my last life, it seems.
Jörn
--
A quarrel is quickly settled when deserted by one party; there is
no battle unless there be two.
-- Seneca
next prev parent reply other threads:[~2008-01-06 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 7:17 [PATCH] block2mtd lockdep_init_map warning Erez Zadok
2008-01-06 13:13 ` Jörn Engel
2008-01-06 13:39 ` Peter Zijlstra
2008-01-06 19:11 ` Erez Zadok
2008-01-06 21:25 ` Jörn Engel [this message]
2008-01-07 10:05 ` Peter Zijlstra
2008-01-07 10:20 ` Jörn Engel
2008-01-07 10:34 ` Peter Zijlstra
2008-01-08 0:47 ` Rusty Russell
2008-01-16 8:16 ` Peter Zijlstra
2008-01-16 21:20 ` Jörn Engel
2008-01-20 21:01 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106212542.GA5262@lazybastard.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).