From: Ingo Molnar <mingo@elte.hu>
To: travis@sgi.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/10] percpu: Per cpu code simplification V3
Date: Tue, 8 Jan 2008 10:07:02 +0100 [thread overview]
Message-ID: <20080108090702.GB27671@elte.hu> (raw)
In-Reply-To: <20080108021142.585467000@sgi.com>
* travis@sgi.com <travis@sgi.com> wrote:
> This patchset simplifies the code that arches need to maintain to
> support per cpu functionality. Most of the code is moved into arch
> independent code. Only a minimal set of definitions is kept for each
> arch.
>
> The patch also unifies the x86 arch so that there is only a single
> asm-x86/percpu.h
>
> V1->V2:
> - Add support for specifying attributes for per cpu declarations (preserves
> IA64 model(small) attribute).
> - Drop first patch that removes the model(small) attribute for IA64
> - Missing #endif in powerpc generic config / Wrong Kconfig
> - Follow Randy's suggestions on how to do the Kconfig settings
>
> V2->V3:
> - fix x86_64 non-SMP case
> - change SHIFT_PTR to SHIFT_PERCPU_PTR
> - fix various percpu_modcopy()'s to reference correct per_cpu_offset()
> - s390 has a special way to determine the pointer to a per cpu area
thanks, i've picked up the x86 and core bits, for testing.
i had the patch below for v2, it's still needed (because i didnt apply
the s390/etc. bits), right?
Ingo
------------->
Subject: x86: let other arches build
From: Ingo Molnar <mingo@elte.hu>
let architectures which still have the DEFINE_PER_CPU/etc. build
properly.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/percpu.h | 2 ++
1 file changed, 2 insertions(+)
Index: linux-x86.q/include/linux/percpu.h
===================================================================
--- linux-x86.q.orig/include/linux/percpu.h
+++ linux-x86.q/include/linux/percpu.h
@@ -14,6 +14,7 @@
#endif
#ifdef CONFIG_SMP
+#ifndef DEFINE_PER_CPU
#define DEFINE_PER_CPU(type, name) \
__attribute__((__section__(".data.percpu"))) \
PER_CPU_ATTRIBUTES __typeof__(type) per_cpu__##name
@@ -32,6 +33,7 @@
#define EXPORT_PER_CPU_SYMBOL(var) EXPORT_SYMBOL(per_cpu__##var)
#define EXPORT_PER_CPU_SYMBOL_GPL(var) EXPORT_SYMBOL_GPL(per_cpu__##var)
+#endif
/* Enough to cover all DEFINE_PER_CPUs in kernel, including modules. */
#ifndef PERCPU_ENOUGH_ROOM
next prev parent reply other threads:[~2008-01-08 9:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 2:11 [PATCH 00/10] percpu: Per cpu code simplification V3 travis
2008-01-08 2:11 ` [PATCH 01/10] percpu: Use a kconfig variable to signal arch specific percpu setup travis
2008-01-08 19:24 ` Sam Ravnborg
2008-01-08 2:11 ` [PATCH 02/10] percpu: Move arch XX_PER_CPU_XX definitions into linux/percpu.h travis
2008-01-08 2:11 ` [PATCH 03/10] percpu: Make the asm-generic/percpu.h more "generic" travis
2008-01-08 2:11 ` [PATCH 04/10] x86_32: Use generic percpu.h travis
2008-01-08 2:11 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 2:11 ` [PATCH 06/10] s390: " travis
2008-01-08 2:11 ` [PATCH 07/10] Powerpc: Use generic per cpu travis
2008-01-08 2:11 ` [PATCH 08/10] Sparc64: Use generic percpu travis
2008-01-08 2:11 ` [PATCH 09/10] ia64: " travis
2008-01-08 2:11 ` [PATCH 10/10] x86: Unify percpu.h travis
2008-01-08 9:07 ` Ingo Molnar [this message]
2008-01-08 16:27 ` [PATCH 00/10] percpu: Per cpu code simplification V3 Mike Travis
2008-01-08 19:04 ` Christoph Lameter
2008-01-08 22:16 ` Ingo Molnar
2008-01-08 23:53 ` Mike Travis
2008-01-08 19:26 ` Sam Ravnborg
2008-01-08 20:29 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108090702.GB27671@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).