Re: do_md_run returned -22 [Was: 2.6.24-rc8-mm1]

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 17 Jan 2008 16:23:30 +0100 Jiri Slaby <jirislaby@gmail.com> wrote:

> On 01/17/2008 11:35 AM, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/
> 
> still the same md issue (do_md_run returns -22=EINVAL) as in -rc6-mm1 reported 
> by Thorsten here:
> http://lkml.org/lkml/2007/12/27/45

hm, I must have been asleep when that was reported.  Neil, did you see it?

> Is there around any fix for this?

Well, we could bitbucket md-allow-devices-to-be-shared-between-md-arrays.patch

> Having 0.90 raid 0 and 1, commenting this out helps:
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8633bd4..9b8ecc8 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3292,8 +3292,8 @@ static int do_md_run(mddev_t * mddev)
>           * Analyze all RAID superblock(s)
>           */
>          if (!mddev->raid_disks) {
> -               if (!mddev->persistent)
> -                       return -EINVAL;
> +/*             if (!mddev->persistent)
> +                       return -EINVAL;*/
>                  analyze_sbs(mddev);
>          }
> 
> The persistency is marked even in analyze_sbs->validate_super, I guess?