From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: jengelh@computergmbh.de
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ak@suse.de, vaf@cisco.com,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] IPv4: Enable use of 240/4 address space
Date: Fri, 18 Jan 2008 11:13:19 +0900 (JST) [thread overview]
Message-ID: <20080118.111319.30002290.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0801180242270.14025@fbirervta.pbzchgretzou.qr>
In article <Pine.LNX.4.64.0801180242270.14025@fbirervta.pbzchgretzou.qr> (at Fri, 18 Jan 2008 02:52:08 +0100 (CET)), Jan Engelhardt <jengelh@computergmbh.de> says:
>
> On Jan 18 2008 10:26, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> >> -#define IN_EXPERIMENTAL(a) ((((long int) (a)) & 0xf0000000) == 0xf0000000)
> >> -#define IN_BADCLASS(a) IN_EXPERIMENTAL((a))
> >
> >No, please keep these macros.
> >
> >> @@ -264,7 +261,7 @@ static inline bool ipv4_is_local_multicast(__be32 addr)
> >>
> >> static inline bool ipv4_is_badclass(__be32 addr)
> >> {
> >> - return (addr & htonl(0xf0000000)) == htonl(0xf0000000);
> >> + return addr == 0xFFFFFFFF;
> >> }
> >>
> >
> >To (un)align the IN_BADCLASS macro and ipv6_is_badclass() definition,
>
> Unalign? IPv6? "Limited" broadcast?
Sorry, ipv4_is_badclass().
Assuming IN_BADCLASS() is still there, we should not reuse the name
of "ipv6_is_badclass" because the their meanings are different.
> -static inline bool ipv4_is_badclass(__be32 addr)
> +static inline bool ipv4_is_broadcast(__be32 addr)
> {
I'm just afraid that people might think ipv4_is_broadcast
is for testing subnet broadcast address.
255.255.255.255 is "limited broadcast address"
(vs subnet broadcast address, which can be forwarded by routers).
--yoshfuji
next prev parent reply other threads:[~2008-01-18 2:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 1:10 [PATCH 001/001] ipv4: enable use of 240/4 address space Vince Fuller
2008-01-11 6:33 ` David Miller
2008-01-11 11:17 ` Andi Kleen
2008-01-11 12:41 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-12 1:48 ` David Miller
2008-01-12 5:12 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-11 17:29 ` Vince Fuller
2008-01-12 1:49 ` David Miller
2008-01-12 11:23 ` Jan Engelhardt
2008-01-12 5:47 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-17 23:04 ` Jan Engelhardt
2008-01-18 0:28 ` Vince Fuller
2008-01-18 1:13 ` [PATCH] IPv4: Enable " Jan Engelhardt
2008-01-18 1:26 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-18 1:52 ` Jan Engelhardt
2008-01-18 2:13 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2008-01-18 2:15 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-19 13:44 ` Jan Engelhardt
2008-01-19 15:30 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-21 11:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118.111319.30002290.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=ak@suse.de \
--cc=davem@davemloft.net \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vaf@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).