From: Andy Whitcroft <apw@shadowen.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: x86: remove casts
Date: Tue, 22 Jan 2008 10:06:24 +0000 [thread overview]
Message-ID: <20080122100609.GA12154@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0801191455180.27831@fbirervta.pbzchgretzou.qr>
On Sat, Jan 19, 2008 at 02:56:05PM +0100, Jan Engelhardt wrote:
>
> On Jan 18 2008 11:45, Ingo Molnar wrote:
> >* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> >
> >> This is against x86/mm.
> >
> >hm, it has checkpatch failures -
>
> All false positives.
The spacing thing is definately a matter for argument elsewhere. I
cirtainly have no real oppinion on the matter. As has been said
elsewhere the coding style is not meant to be as everyone likes it, more
a minimally offensive common position generating consistancy out of
caos.
Checkpatch is _meant_ to push you towards the recommendations in
CodingStyle, that is the definative resource; common sense should prevail
over it. <standard message>checkpatch is a style guide only, think
about its output and be prepared to justify any non-complience.</standard
message>.
The second one is a clear falsie which I believe I have fixed for the
next release, rather over zelous "possible type" detection has fired here.
ERROR: "foo * bar" should be "foo *bar"
#123: FILE: arch/x86/kernel/microcode.c:248:
+ EXT_SIGNATURE_SIZE * i;
Cheers.
-apw
prev parent reply other threads:[~2008-01-22 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 21:15 x86: remove casts Jan Engelhardt
2008-01-16 22:20 ` Kyle McMartin
2008-01-16 22:57 ` Jan Engelhardt
2008-01-17 6:43 ` Kyle McMartin
2008-01-17 22:22 ` Jan Engelhardt
2008-01-18 10:45 ` Ingo Molnar
2008-01-19 13:56 ` Jan Engelhardt
2008-01-19 14:08 ` Ingo Molnar
2008-01-19 14:26 ` Jan Engelhardt
2008-01-22 10:06 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122100609.GA12154@shadowen.org \
--to=apw@shadowen.org \
--cc=hpa@zytor.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).