From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Dave Young <hidave.darkstar@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] sched: don't take a mutex from interrupt context
Date: Tue, 22 Jan 2008 22:21:21 +0530 [thread overview]
Message-ID: <20080122165121.GE31049@linux.vnet.ibm.com> (raw)
In-Reply-To: <1201019138.6341.24.camel@lappy>
On Tue, Jan 22, 2008 at 05:25:38PM +0100, Peter Zijlstra wrote:
> @@ -1428,9 +1428,9 @@ static void print_cfs_stats(struct seq_f
> #ifdef CONFIG_FAIR_GROUP_SCHED
> print_cfs_rq(m, cpu, &cpu_rq(cpu)->cfs);
> #endif
> - lock_task_group_list();
> + rcu_read_lock();
> for_each_leaf_cfs_rq(cpu_rq(cpu), cfs_rq)
> print_cfs_rq(m, cpu, cfs_rq);
Isn't there a possibility that print_cfs_rq() can block?
> - unlock_task_group_list();
> + rcu_read_unlock();
> }
> #endif
>
--
Regards,
vatsa
next prev parent reply other threads:[~2008-01-22 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 2:36 WARNING: at kernel/mutex.c:134 Dave Young
2008-01-22 16:25 ` [PATCH] sched: don't take a mutex from interrupt context Peter Zijlstra
2008-01-22 16:51 ` Srivatsa Vaddagiri [this message]
2008-01-22 16:47 ` Peter Zijlstra
2008-01-22 17:23 ` Srivatsa Vaddagiri
2008-01-22 17:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122165121.GE31049@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).