Re: [PATCH 1/2] x86: GEODE fix MFGPT input clock value

From: Willy Tarreau <w@1wt.eu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Arnd Hannemann <hannemann@i4.informatik.rwth-aachen.de>,
	Jordan Crouse <jordan.crouse@amd.com>, Lars Heete <hel@admin.de>,
	Andres Salomon <dilinger@queued.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] x86: GEODE fix MFGPT input clock value
Date: Wed, 23 Jan 2008 23:11:29 +0100	[thread overview]
Message-ID: <20080123221129.GA27022@1wt.eu> (raw)
In-Reply-To: <4797B8C4.9060102@zytor.com>

Hi Peter,

On Wed, Jan 23, 2008 at 01:59:32PM -0800, H. Peter Anvin wrote:
> Willy Tarreau wrote:
> >The GEODE MFGPT code assumed that 32kHz was 32000 Hz while the boards
> >run on a 32.768 kHz digital watch crystal. In practise, it will not
> >change the timer's frequency as the skew was only 2.4%, but it
> >should provide more accurate intervals.
> >- *  Divisor   Hz      Min Delta (S) Max Delta (S)
> 
> Seconds are "s", not "S" (S = siemens.)

You're quite right. Same as we should write kHz and not Khz. But I'm
used to change other people's work and particularly comments the least
possible. Do you want an update ?

Willy