From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code
Date: Tue, 19 Feb 2008 17:37:20 +0200 [thread overview]
Message-ID: <20080219153720.GA2967@ubuntu> (raw)
Hi all,
Avoid duplicating __tasklet_schedule() and __tasklet_hi_schedule()
code in tasklet_action() and tasklet_hi_action() respectively.
Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
---
This also saves a few bytes of image space:
text data bss dec hex filename
3632 12 324 3968 f80 softirq.o.before
3552 12 324 3888 f30 softirq.o.after
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 5b3aea5..3068dc3 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -414,11 +414,8 @@ static void tasklet_action(struct softirq_action *a)
tasklet_unlock(t);
}
- local_irq_disable();
- t->next = __get_cpu_var(tasklet_vec).list;
- __get_cpu_var(tasklet_vec).list = t;
- __raise_softirq_irqoff(TASKLET_SOFTIRQ);
- local_irq_enable();
+ /* We were not lucky enough to run, reschedule. */
+ __tasklet_schedule(t);
}
}
@@ -447,11 +444,8 @@ static void tasklet_hi_action(struct softirq_action *a)
tasklet_unlock(t);
}
- local_irq_disable();
- t->next = __get_cpu_var(tasklet_hi_vec).list;
- __get_cpu_var(tasklet_hi_vec).list = t;
- __raise_softirq_irqoff(HI_SOFTIRQ);
- local_irq_enable();
+ /* We were not lucky enough to run, reschedule. */
+ __tasklet_hi_schedule(t);
}
}
Regards,
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
next reply other threads:[~2008-02-19 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:37 Ahmed S. Darwish [this message]
2008-02-19 15:52 ` [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code Ingo Molnar
2008-02-19 16:27 ` Ahmed S. Darwish
2008-02-20 10:41 ` Ingo Molnar
2008-02-20 13:37 ` Ahmed S. Darwish
2008-02-20 14:20 ` Dmitry Adamushko
2008-02-20 19:39 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219153720.GA2967@ubuntu \
--to=darwish.07@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).