From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762320AbYCFTFd (ORCPT ); Thu, 6 Mar 2008 14:05:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759993AbYCFTFU (ORCPT ); Thu, 6 Mar 2008 14:05:20 -0500 Received: from mx1.redhat.com ([66.187.233.31]:59497 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbYCFTFS (ORCPT ); Thu, 6 Mar 2008 14:05:18 -0500 From: Josef Bacik To: Jan Kara Subject: Re: [RFC] JBD ordered mode rewrite Date: Thu, 6 Mar 2008 14:05:03 -0500 User-Agent: KMail/1.9.9 Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20080306174209.GA14193@duck.suse.cz> In-Reply-To: <20080306174209.GA14193@duck.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803061405.03721.jbacik@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 06 March 2008 12:42:09 pm Jan Kara wrote: > Hi, > > Below is my rewrite of ordered mode in JBD. Now we don't have a list of > data buffers that need syncing on transaction commit but a list of inodes > that need writeout during commit. This brings all sorts of advantages such > as possibility to get rid of journal heads and buffer heads for data > buffers in ordered mode, better ordering of writes on transaction commit, > simplification of some JBD code, no more anonymous pages when truncate of > data being committed happens. The patch has survived some light testing > but it still has some potential of eating your data so beware :) I've run > dbench to see whether we didn't decrease performance by different handling > of truncate and the throughput I'm getting on my machine is the same (OK, > is lower by 0.5%) if I disable the code in truncate waiting for commit to > finish... Also the throughput of dbench is about 2% better with my patch > than with current JBD. > Any comments or testing most welcome. > > Honza Just one nit, doesn't compile properly when jbd/ext3 are modules :). Thanks much, Josef