From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Li Shaohua <shaohua.li@intel.com>
Cc: Matthieu Castet <castet.matthieu@free.fr>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Rene Herman <rene.herman@keyaccess.nl>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [patch 19/37] PNP: remove pnp_resource_table from internal pnp_clean_resource_table interface
Date: Wed, 26 Mar 2008 11:11:17 -0600 [thread overview]
Message-ID: <20080326171227.131971545@ldl.fc.hp.com> (raw)
In-Reply-To: 20080326171058.099442579@ldl.fc.hp.com
[-- Attachment #1: pnp-remove-pnp_resource_table-from-clean --]
[-- Type: text/plain, Size: 1538 bytes --]
This changes pnp_clean_resource_table() to take a pnp_dev pointer
rather than a pnp_resource_table pointer. This reduces the visibility
of pnp_resource_table and removes an opportunity for error in the
caller.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work7/drivers/pnp/manager.c
===================================================================
--- work7.orig/drivers/pnp/manager.c 2008-03-25 11:03:59.000000000 -0600
+++ work7/drivers/pnp/manager.c 2008-03-25 11:04:52.000000000 -0600
@@ -247,8 +247,9 @@
* pnp_clean_resources - clears resources that were not manually set
* @res: the resources to clean
*/
-static void pnp_clean_resource_table(struct pnp_resource_table *res)
+static void pnp_clean_resource_table(struct pnp_dev *dev)
{
+ struct pnp_resource_table *res = &dev->res;
int idx;
for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
@@ -304,7 +305,7 @@
return -ENODEV;
mutex_lock(&pnp_res_mutex);
- pnp_clean_resource_table(&dev->res); /* start with a fresh slate */
+ pnp_clean_resource_table(dev);
if (dev->independent) {
port = dev->independent->port;
mem = dev->independent->mem;
@@ -376,7 +377,7 @@
return 1;
fail:
- pnp_clean_resource_table(&dev->res);
+ pnp_clean_resource_table(dev);
mutex_unlock(&pnp_res_mutex);
return 0;
}
@@ -554,7 +555,7 @@
/* release the resources so that other devices can use them */
mutex_lock(&pnp_res_mutex);
- pnp_clean_resource_table(&dev->res);
+ pnp_clean_resource_table(dev);
mutex_unlock(&pnp_res_mutex);
return 0;
--
next prev parent reply other threads:[~2008-03-26 17:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 17:10 [patch 00/37] PNP resource_table cleanups Bjorn Helgaas
2008-03-26 17:10 ` [patch 01/37] ISAPNP: move config register addresses out of isapnp.h Bjorn Helgaas
2008-03-26 17:11 ` [patch 02/37] PNPACPI: continue after _CRS and _PRS errors Bjorn Helgaas
2008-03-26 17:11 ` [patch 03/37] PNP: make pnp_add_id() internal to PNP core Bjorn Helgaas
2008-03-26 17:11 ` [patch 04/37] PNP: change pnp_add_id() to allocate its own pnp_id structures Bjorn Helgaas
2008-03-26 17:11 ` [patch 05/37] ISAPNP: pull pnp_add_id() out of isapnp_parse_id() Bjorn Helgaas
2008-03-26 17:11 ` [patch 06/37] PNP: add pnp_alloc_dev() Bjorn Helgaas
2008-03-26 17:11 ` [patch 07/37] PNP: make pnp_add_card_id() internal to PNP core Bjorn Helgaas
2008-03-26 17:11 ` [patch 08/37] PNP: change pnp_add_card_id() to allocate its own pnp_id structures Bjorn Helgaas
2008-03-26 17:11 ` [patch 09/37] ISAPNP: pull pnp_add_card_id() out of isapnp_parse_card_id() Bjorn Helgaas
2008-03-26 17:11 ` [patch 10/37] PNP: add pnp_alloc_card() Bjorn Helgaas
2008-03-26 17:11 ` [patch 11/37] PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "extended_irq" Bjorn Helgaas
2008-03-26 17:11 ` [patch 12/37] PNPACPI: use temporaries to reduce repetition Bjorn Helgaas
2008-03-26 17:11 ` [patch 13/37] PNPACPI: hoist dma_flags() out of pnpacpi_parse_allocated_dmaresource() Bjorn Helgaas
2008-03-26 17:11 ` [patch 14/37] PNPACPI: extend irq_flags() to set IORESOURCE_IRQ_SHAREABLE when appropriate Bjorn Helgaas
2008-03-26 17:11 ` [patch 15/37] PNPACPI: pass pnp_dev instead of acpi_handle Bjorn Helgaas
2008-03-26 17:11 ` [patch 16/37] PNP: remove pnp_resource_table from internal get/set interfaces Bjorn Helgaas
2008-03-26 17:11 ` [patch 17/37] PNP: remove more pnp_resource_table arguments Bjorn Helgaas
2008-03-26 17:11 ` [patch 18/37] PNP: add pnp_init_resources(struct pnp_dev *) interface Bjorn Helgaas
2008-03-26 17:11 ` Bjorn Helgaas [this message]
2008-03-26 17:11 ` [patch 20/37] PNP: make generic pnp_add_irq_resource() Bjorn Helgaas
2008-03-26 17:11 ` [patch 21/37] PNP: make generic pnp_add_dma_resource() Bjorn Helgaas
2008-03-26 17:11 ` [patch 22/37] PNP: make generic pnp_add_io_resource() Bjorn Helgaas
2008-03-26 17:11 ` [patch 23/37] PNP: make generic pnp_add_mem_resource() Bjorn Helgaas
2008-03-26 17:11 ` [patch 24/37] PNP: use dev_printk when possible Bjorn Helgaas
2008-03-26 17:11 ` [patch 25/37] PNPACPI: remove redundant warnings about _CRS/_PRS failures Bjorn Helgaas
2008-03-26 17:11 ` [patch 26/37] PNPACPI: remove some pnp_dbg calls Bjorn Helgaas
2008-03-26 17:11 ` [patch 27/37] PNP: use conventional "i" for loop indices Bjorn Helgaas
2008-03-26 17:11 ` [patch 28/37] PNP: add pnp_get_resource() interface Bjorn Helgaas
2008-03-26 23:15 ` Bjorn Helgaas
2008-03-26 17:11 ` [patch 29/37] PNP: convert encoders to use pnp_get_resource(), not pnp_resource_table Bjorn Helgaas
2008-03-26 17:11 ` [patch 30/37] PNP: convert resource accessors " Bjorn Helgaas
2008-03-26 17:11 ` [patch 31/37] PNP: convert resource checks " Bjorn Helgaas
2008-03-26 17:11 ` [patch 32/37] PNP: convert resource assign functions " Bjorn Helgaas
2008-03-26 17:11 ` [patch 33/37] PNP: remove PNP_MAX_* uses Bjorn Helgaas
2008-03-26 17:11 ` [patch 34/37] PNP: remove unused interfaces using pnp_resource_table Bjorn Helgaas
2008-03-26 17:11 ` [patch 35/37] rtc: dont reference pnp_resource_table directly Bjorn Helgaas
2008-03-26 17:11 ` [patch 36/37] PNP: make pnp_resource_table private to PNP core Bjorn Helgaas
2008-03-26 17:11 ` [patch 37/37] PNP: make interfaces private to the " Bjorn Helgaas
2008-03-26 22:42 ` [patch 00/37] PNP resource_table cleanups Len Brown
2008-03-26 23:13 ` Bjorn Helgaas
2008-03-27 0:30 ` Rene Herman
2008-03-27 17:50 ` Bjorn Helgaas
2008-03-31 19:40 ` Rene Herman
2008-03-31 19:48 ` Rene Herman
2008-03-31 20:51 ` Bjorn Helgaas
2008-03-31 21:38 ` Rene Herman
2008-04-01 10:16 ` Rene Herman
2008-04-01 14:52 ` Bjorn Helgaas
2008-04-01 15:16 [patch 00/37] PNP resource_table cleanups, v2 Bjorn Helgaas
2008-04-01 15:16 ` [patch 19/37] PNP: remove pnp_resource_table from internal pnp_clean_resource_table interface Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326171227.131971545@ldl.fc.hp.com \
--to=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).