From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765010AbYEFJSZ (ORCPT ); Tue, 6 May 2008 05:18:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763619AbYEFJOc (ORCPT ); Tue, 6 May 2008 05:14:32 -0400 Received: from fxip-0047f.externet.hu ([88.209.222.127]:59522 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763304AbYEFJO3 (ORCPT ); Tue, 6 May 2008 05:14:29 -0400 Message-Id: <20080506091417.195070762@szeredi.hu> References: <20080506091327.259950960@szeredi.hu> User-Agent: quilt/0.45-1 Date: Tue, 06 May 2008 11:13:36 +0200 From: Miklos Szeredi To: akpm@linux-foundation.org Cc: hch@infradead.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [patch 09/24] vfs: truncate: dont check immutable twice Content-Disposition: inline; filename=truncate_immutable_cleanup.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi vfs_permission(MAY_WRITE) already checked for the inode being immutable, so no need to repeat it. Signed-off-by: Miklos Szeredi --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/fs/open.c =================================================================== --- linux-2.6.orig/fs/open.c 2008-05-06 11:04:35.000000000 +0200 +++ linux-2.6/fs/open.c 2008-05-06 11:04:35.000000000 +0200 @@ -254,7 +254,7 @@ static long do_sys_truncate(const char _ goto mnt_drop_write_and_out; error = -EPERM; - if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) + if (IS_APPEND(inode)) goto mnt_drop_write_and_out; error = get_write_access(inode); --