linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
	viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Subject: Re: [patch 06/24] hpfs: dont call notify_change
Date: Thu, 8 May 2008 12:52:47 -0400	[thread overview]
Message-ID: <20080508165247.GC13914@infradead.org> (raw)
In-Reply-To: <20080506091413.165665963@szeredi.hu>

On Tue, May 06, 2008 at 11:13:33AM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> hpfs_unlink() calls notify_change() to truncate the file before
> deleting.  Replace with explicit call to hpfs_notify_change().
> 
> This is equivalent, except that:
>  - security_inode_setattr() is not called before hpfs_notify_change()
>  - fsnotify_change() is not called after hpfs_notify_change()
> 
> The truncation is just an implementation detail, so both the security
> check and the notification are unnecessary.
> 
> Possibly even the ctime modification is wrong?

This code is rahter scary, as we'd lost the content without the file
when the second remove_dirent attempt fails.  Because of that we should
at least keep the ctime change so an app can know the file was touched.

Again, looks correct but I'm not convinced about all these changes.

  parent reply	other threads:[~2008-05-08 16:53 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06  9:13 [patch 00/24] vfs: fixes and cleanups + add helpers to check r/o bind mounts Miklos Szeredi
2008-05-06  9:13 ` [patch 01/24] nfsd: clean up mnt_want_write calls Miklos Szeredi
2008-05-06  9:13 ` [patch 02/24] cgroup: dont call vfs_mkdir Miklos Szeredi
2008-05-06  9:13 ` [patch 03/24] reiserfs: dont call vfs_rmdir Miklos Szeredi
2008-05-06  9:13 ` [patch 04/24] reiserfs: dont call notify_change Miklos Szeredi
2008-05-08 16:49   ` Christoph Hellwig
2008-05-06  9:13 ` [patch 05/24] sysfs: " Miklos Szeredi
2008-05-08 16:50   ` Christoph Hellwig
2008-05-06  9:13 ` [patch 06/24] hpfs: " Miklos Szeredi
2008-05-08  0:41   ` Mikulas Patocka
2008-05-08 16:52   ` Christoph Hellwig [this message]
2008-05-09  1:59     ` Mikulas Patocka
2008-05-06  9:13 ` [patch 07/24] fat: " Miklos Szeredi
2008-05-08 16:57   ` Christoph Hellwig
2008-05-08 18:51     ` Miklos Szeredi
2008-05-08 19:42     ` OGAWA Hirofumi
2008-05-08 23:45     ` James Morris
2008-05-06  9:13 ` [patch 08/24] vfs: immutable inode checking cleanup Miklos Szeredi
2008-05-15  7:23   ` Al Viro
2008-05-15  7:39     ` Miklos Szeredi
2008-05-06  9:13 ` [patch 09/24] vfs: truncate: dont check immutable twice Miklos Szeredi
2008-05-06  9:13 ` [patch 10/24] vfs: truncate: append-only checking cleanup Miklos Szeredi
2008-05-15  7:49   ` Al Viro
2008-05-15  7:58     ` Miklos Szeredi
2008-05-06  9:13 ` [patch 11/24] vfs: create file_truncate() helper Miklos Szeredi
2008-05-06  9:13 ` [patch 12/24] vfs: utimes immutable fix Miklos Szeredi
2008-05-06  9:13 ` [patch 13/24] vfs: utimes cleanup Miklos Szeredi
2008-05-06 10:03   ` Miklos Szeredi
2008-05-15  7:39     ` Al Viro
2008-05-15  7:45       ` Miklos Szeredi
2008-05-06  9:13 ` [patch 14/24] vfs: splice remove_suid() cleanup Miklos Szeredi
2008-05-06  9:13 ` [patch 15/24] vfs: add path_create() and path_mknod() Miklos Szeredi
2008-05-06  9:13 ` [patch 16/24] vfs: add path_mkdir() Miklos Szeredi
2008-05-06  9:13 ` [patch 17/24] vfs: add path_rmdir() Miklos Szeredi
2008-05-06  9:13 ` [patch 18/24] vfs: add path_unlink() Miklos Szeredi
2008-05-06  9:13 ` [patch 19/24] vfs: add path_symlink() Miklos Szeredi
2008-05-06  9:13 ` [patch 20/24] vfs: add path_link() Miklos Szeredi
2008-05-06  9:13 ` [patch 21/24] vfs: add path_rename() Miklos Szeredi
2008-05-06  9:13 ` [patch 22/24] vfs: add path_setattr() Miklos Szeredi
2008-05-06  9:13 ` [patch 23/24] vfs: add path_setxattr() Miklos Szeredi
2008-05-06  9:13 ` [patch 24/24] vfs: add path_removexattr() Miklos Szeredi
2008-05-06  9:16 ` [patch 00/24] vfs: fixes and cleanups + add helpers to check r/o bind mounts Christoph Hellwig
2008-05-06 10:33   ` Miklos Szeredi
2008-05-14 14:55     ` Pavel Machek
2008-05-07 11:57 ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080508165247.GC13914@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).