From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>, Greg KH <greg@kroah.com>,
benh@kernel.crashing.org,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
tony@bakeyournoodle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c
Date: Fri, 9 May 2008 07:32:40 +0200 [thread overview]
Message-ID: <20080509073240.49f09ac2@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1210291364.19279.62.camel@brick>
On Thu, 08 May 2008 17:02:44 -0700,
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Fri, 2008-05-09 at 09:50 +1000, Paul Mackerras wrote:
> > I think the best solution is to make a new sysfs_maybe_create_file()
> > which isn't marked must_check, and then move suitable callers (such as
> > radeonfb) over to that. That will make it obvious in the callers that
> > the file creation isn't guaranteed.
Either that...
>
> Or just a a flag parameter to the existing one that says whether failure
> is allowed or not. In a case that fails, a WARN_ON can be printed from
> the common create_file rather than putting printks all over the kernel.
...or that. But the core should still warn about duplicate files in all
cases, since that indicates a bug. (And that will catch the problems we
found before; IIRC a core warning didn't exist back then.)
>
> This would also document which files are necessary vs. optional.
Shouldn't that rather go into Documentation/ABI/, so that people can
easily find out what they may rely on?
next prev parent reply other threads:[~2008-05-09 5:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 4:34 [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c Tony Breeds
2008-05-06 21:39 ` Andrew Morton
2008-05-06 21:43 ` David Miller
2008-05-06 21:56 ` Andrew Morton
2008-05-07 4:00 ` Arjan van de Ven
2008-05-07 4:12 ` Andrew Morton
2008-05-07 4:15 ` Arjan van de Ven
2008-05-07 4:20 ` Arjan van de Ven
2008-05-07 4:37 ` Benjamin Herrenschmidt
2008-05-07 4:23 ` Andrew Morton
2008-05-07 4:26 ` Andrew Morton
2008-05-07 4:41 ` Arjan van de Ven
2008-05-07 4:37 ` Arjan van de Ven
2008-05-07 5:40 ` Paul Mackerras
2008-05-07 5:49 ` Benjamin Herrenschmidt
2008-05-07 0:54 ` Benjamin Herrenschmidt
2008-05-07 1:20 ` Andrew Morton
2008-05-07 4:33 ` Benjamin Herrenschmidt
2008-05-07 8:23 ` Cornelia Huck
2008-05-07 21:43 ` Benjamin Herrenschmidt
2008-05-08 7:34 ` Cornelia Huck
2008-05-08 7:49 ` Benjamin Herrenschmidt
2008-05-08 8:36 ` Cornelia Huck
2008-05-08 22:03 ` Greg KH
2008-05-08 23:06 ` Benjamin Herrenschmidt
2008-05-08 23:50 ` Paul Mackerras
2008-05-09 0:02 ` Harvey Harrison
2008-05-09 5:32 ` Cornelia Huck [this message]
2008-05-09 5:33 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509073240.49f09ac2@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).