From: Ingo Molnar <mingo@elte.hu>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Kevin Winchester <kjwinchester@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: Latest Linus git: kernel/sched.c:1216: warning: ‘init_hrtick’ defined but not used
Date: Tue, 13 May 2008 19:17:34 +0200 [thread overview]
Message-ID: <20080513171734.GA6792@elte.hu> (raw)
In-Reply-To: <20080513153403.GA4474@linux.vnet.ibm.com>
* Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:
> > > I could write up the simple patch to put #ifdef CONFIG_SMP around
> > > init_hrtick(), but with all of the #ifdefs in that file, I figure
> > > it is probably a little more complicated than that.
> >
> > the fix seems simple - see below. The #ifdef jungle ... less so.
>
> I attempted to make it a bit easier to figure out that jungle at
> http://lkml.org/lkml/2008/5/12/64 , if it helps.
yeah, applied it - it definitely helps. Would be better to hide most of
these complications in include files though.
Ingo
next prev parent reply other threads:[~2008-05-13 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 23:55 Latest Linus git: kernel/sched.c:1216: warning: ‘init_hrtick’ defined but not used Kevin Winchester
2008-05-13 13:23 ` Ingo Molnar
2008-05-13 15:34 ` Dhaval Giani
2008-05-13 17:17 ` Ingo Molnar [this message]
2008-05-26 23:04 ` Latest Linus git: kernel/sched.c:1216: warning: ?init_hrtick? " Kevin Winchester
2008-06-17 8:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513171734.GA6792@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).