From: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>
To: "cj" <christophe.jaillet@wanadoo.fr>,
"linux" <linux-kernel@vger.kernel.org>, <hskinnemoen@atmel.com>,
<jeff@garzik.org>, <gregerts@stud.ntnu.no>
Subject: [PATCH 1/1] avr32/pata: avoid unnecessary memset (updated after comments)
Date: Tue, 13 May 2008 21:17:30 +0200 [thread overview]
Message-ID: <20080513191732.5B0B31C0008D@mwinf2713.orange.fr> (raw)
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Hi, here is a patch against linux/drivers/ata/pata_at32.c which :
1) Remove an explicit memset(.., 0, ...) to a variable allocated with
kzalloc (i.e. 'info').
Note: this patch is based on 'linux-2.6.25.tar.bz2'
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
---
--- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
+++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
@@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
if (!info)
return -ENOMEM;
- memset(info, 0, sizeof(struct at32_ide_info));
-
info->irq = irq;
info->cs = board->cs;
next reply other threads:[~2008-05-13 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 19:17 Christophe Jaillet [this message]
2008-05-19 21:42 ` [PATCH 1/1] avr32/pata: avoid unnecessary memset (updated after comments) Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513191732.5B0B31C0008D@mwinf2713.orange.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=gregerts@stud.ntnu.no \
--cc=hskinnemoen@atmel.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).