From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759018AbYEMTdV (ORCPT ); Tue, 13 May 2008 15:33:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755708AbYEMTdK (ORCPT ); Tue, 13 May 2008 15:33:10 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:45610 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755399AbYEMTdI convert rfc822-to-8bit (ORCPT ); Tue, 13 May 2008 15:33:08 -0400 Message-ID: <20080513213330.utev64tlw4ss0kgw@intran0x.frec.bull.fr> Date: Tue, 13 May 2008 21:33:30 +0200 From: "Benjamin Thery " To: Greg KH Cc: "Eric W. Biederman" , Randy Dunlap , Greg KH , Andrew Morton , linux-kernel@vger.kernel.org, Tejun Heo , Al Viro , Daniel Lezcano , "Serge E. Hallyn" , Pavel Emelyanov , netdev@vger.kernel.org Subject: Re: kobject: Fix kobject_rename and !CONFIG_SYSFS References: <20080512220232.GA16914@kroah.com> <4829A4BD.3020007@bull.net> <20080513164438.GA31563@kroah.com> In-Reply-To: <20080513164438.GA31563@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; DelSp=Yes format=flowed Content-Disposition: inline Content-Transfer-Encoding: 7BIT User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Greg KH : > On Tue, May 13, 2008 at 04:25:01PM +0200, Benjamin Thery wrote: >> Eric W. Biederman wrote: >>> Greg KH writes: >>>> Eric, Randy Dunlap has found that this patch breaks the build when >>>> CONFIG_SYSFS is not enabled. Can you please fix it up before I send it >>>> to Linus? >>>> >>>> The exact error is: >>>> In file included from >>>> /local/linsrc/next-20080509/include/linux/kobject.h:21, >>>> from >>>> /local/linsrc/next-20080509/include/linux/module.h:16, >>>> from >>>> /local/linsrc/next-20080509/include/linux/crypto.h:21, >>>> from >>>> /local/linsrc/next-20080509/arch/x86/kernel/asm-offsets_64.c:7, >>>> from >>>> /local/linsrc/next-20080509/arch/x86/kernel/asm-offsets.c:4: >>>> /local/linsrc/next-20080509/include/linux/sysfs.h: In function >>>> 'sysfs_rename_dir': >>>> /local/linsrc/next-20080509/include/linux/sysfs.h:142: error: implicit >>>> declaration of function 'kobject_set_name' >>> I will take a look in the morning and see if I can see what is wrong. >>> Which tree was this error against? I thought I tested this case, >>> and I'm wondering if there might be another patch that is hiding >>> kobject_set_name. >> >> Argh, headers "cross-dependencies": >> >> * linux/kobject.h includes linux/sysfs.h before defining >> kobject_set_name() >> >> * linux/sysfs.h needs to include linux/kobject.h to find >> kobject_set_name() definition (for inlined sysfs_rename_dir() when >> CONFIG_SYSFS=n) >> >> >> sysfs_rename_dir() is only called by kobject.c, kobject_rename(). >> I guess this kind of patch is not acceptable to fix the depency? > > Ick, no. I'd rather add a kobject_set_name() function prototype to > sysfs.h in this case, that should remove the error, right? That's what I did first. But I thought it was worse than the above solution. Anyway, adding kobject_set_name() to sysfs.h did fix the error. -Benjamin > > thanks, > > greg k-h > > ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.