linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OSS trident: switch from ->write_proc
Date: Wed, 14 May 2008 08:47:08 +0300	[thread overview]
Message-ID: <20080514054707.GB6682@il.ibm.com> (raw)
In-Reply-To: <20080513210544.GB23977@martell.zuzino.mipt.ru>

Thanks Alexey, some comments below. This patch is a step in the right
direction but I'm afraid it's currently broken.

On Wed, May 14, 2008 at 01:05:44AM +0400, Alexey Dobriyan wrote:

> @@ -4441,11 +4446,8 @@ trident_probe(struct pci_dev *pci_dev, const struct pci_device_id *pci_id)
>  		/* ALi SPDIF OUT function */
>  		if (card->revision == ALI_5451_V02) {
>  			ali_setup_spdif_out(card, ALI_PCM_TO_SPDIF_OUT);
> -			res = create_proc_entry("ALi5451", 0, NULL);
> -			if (res) {
> -				res->write_proc = ali_write_proc;
> -				res->data = card;
> -			}
> +			proc_create_data("ALi5451", 0, NULL,
> +					 &ali_proc_fops, card);
>  		}
>  
>  		/* Add H/W Volume Control By Matt Wu Jul. 06, 2001 */

This is not enough--we need to also remove the proc_entry if
trident_probe() fails (see label `out_proc_fs'), which will require
checking if proc_create_data() succeeded. Please send an updated patch
or let me know and I'll take care of it.

Also, I no longer have working trident hardware---if someone else does
and can test this, please let me know. Otherwise we can should
probably go ahead and remove this old OSS driver.

Cheers,
Muli

  reply	other threads:[~2008-05-14  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 21:05 [PATCH] OSS trident: switch from ->write_proc Alexey Dobriyan
2008-05-14  5:47 ` Muli Ben-Yehuda [this message]
2008-05-14 20:49   ` Alexey Dobriyan
2008-05-15 16:48     ` Muli Ben-Yehuda
2008-05-16  0:23   ` [RFC: 2.6 patch] remove the OSS trident driver Adrian Bunk
2008-05-18  6:45     ` Muli Ben-Yehuda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080514054707.GB6682@il.ibm.com \
    --to=muli@il.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).