linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: janitor work in bugs.c
Date: Fri, 16 May 2008 15:48:58 +0200	[thread overview]
Message-ID: <20080516134858.GC28910@elte.hu> (raw)
In-Reply-To: <1210695109-31727-1-git-send-email-vmiklos@frugalware.org>


* Miklos Vajna <vmiklos@frugalware.org> wrote:

> -/* trap_init() enabled FXSR and company _before_ testing for FP problems here. */
> +/* 
> + * trap_init() enabled FXSR and company _before_ testing for FP problems
> + * here.
> + */
>  	/* Test for the divl bug.. */
>  	__asm__("fninit\n\t"
>  		"fldl %1\n\t"

the two comments should be merged, somehow like this:

> +	/* 
> +	 * trap_init() enabled FXSR and company _before_ testing for FP 
> +	 * problems here.
> +	 *
> +	 * Test for the divl bug:
> +	 */
>  	__asm__("fninit\n\t"

>  	check_popad();
> -	init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
> +	init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 :
> +	    boot_cpu_data.x86);

hm, that looks a bit ugly. It's nicer to have something like:

> +	init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 :
> +							boot_cpu_data.x86);

i.e. have a continuation of the right side of the expression, and have 
it close to where it was broken from.

or just do:

> +	init_utsname()->machine[1] =
> +		 '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);

	Ingo

  reply	other threads:[~2008-05-16 13:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 11:35 [PATCH 1/3] x86: janitor work in video-vga.c Miklos Vajna
2008-05-13 11:35 ` [PATCH 2/3] x86: janitor work in bugs.c Miklos Vajna
2008-05-13 11:35   ` [PATCH 3/3] x86: janitor work in irq.c Miklos Vajna
2008-05-13 12:46     ` Ingo Molnar
2008-05-13 16:38       ` [PATCH] " Miklos Vajna
2008-05-16 17:28         ` Jesse Barnes
2008-05-13 12:44   ` [PATCH 2/3] x86: janitor work in bugs.c Ingo Molnar
2008-05-13 16:11     ` [PATCH] " Miklos Vajna
2008-05-16 13:48       ` Ingo Molnar [this message]
2008-05-17 20:48         ` Miklos Vajna
2008-05-13 21:09   ` [PATCH 2/3] " Andi Kleen
2008-05-13 21:44     ` Miklos Vajna
2008-05-14  0:21     ` Joe Perches
2008-05-14  4:44       ` H. Peter Anvin
2008-05-13 12:42 ` [PATCH 1/3] x86: janitor work in video-vga.c Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080516134858.GC28910@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).