From: Andrew Morton <akpm@linux-foundation.org>
To: Chandru <chandru@in.ibm.com>
Cc: muli@il.ibm.com, linux-kernel@vger.kernel.org,
alexisb@us.ibm.com, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [RFC] [Patch] calgary iommu: Use the first kernel's tce tables in kdump
Date: Thu, 17 Jul 2008 16:14:14 -0700 [thread overview]
Message-ID: <20080717161414.c5a267f7.akpm@linux-foundation.org> (raw)
In-Reply-To: <200807151415.27845.chandru@in.ibm.com>
On Tue, 15 Jul 2008 14:15:27 +0530
Chandru <chandru@in.ibm.com> wrote:
> kdump kernel fails to boot with calgary iommu and aacraid driver on a x366
> box. The ongoing dma's of aacraid from the first kernel continue to exist
> until the driver is loaded in the kdump kernel. Calgary is initialized prior
> to aacraid and creation of new tce tables causes wrong dma's to occur. Here
> we try to get the tce tables of the first kernel in kdump kernel and use
> them. While in the kdump kernel we do not allocate new tce tables but instead
> read the base addres register contents of calgary iommu and use the tables
> that the registers point to. With these changes the kdump kernel and hence
> aacraid now boots normally.
>
> Signed-off-by: Chandru Siddalingappa <chandru@in.ibm.com>
> ---
>
> patch taken on top of linux-2.6.26 stable. Comments from Muli Ben-Yehuda taken
> into consideration. Pls apply it as a stop-gap patch until we can come up
> with a more stable patch for this issue. Thanks,
Is this needed in 2.6.26?
If so, the patch whcih I applied will need a little work because I had
to touch up some rejects against already-queued changes. I can fix
that issue by applying this _ahead_ of those changes, but I'm just not
able to judge whether this is needed from the information which was
provided.
> diff -Narup linux-2.6.26-orig/arch/x86/kernel/pci-calgary_64.c
> linux-2.6.26/arch/x86/kernel/pci-calgary_64.c
> --- linux-2.6.26-orig/arch/x86/kernel/pci-calgary_64.c 2008-07-15
> 13:36:00.000000000 +0530
> +++ linux-2.6.26/arch/x86/kernel/pci-calgary_64.c 2008-07-15
> 13:45:36.000000000 +0530
> @@ -36,6 +36,7 @@
> #include <linux/delay.h>
> #include <linux/scatterlist.h>
> #include <linux/iommu-helper.h>
> +#include <linux/crash_dump.h>
You don't _have_ to put new includes right at the end of the list!
Everyone does this, and it just maximises the probability of merge
conflcits :(
> #include <asm/gart.h>
> #include <asm/calgary.h>
> #include <asm/tce.h>
> @@ -167,6 +168,8 @@ static void calgary_dump_error_regs(stru
> static void calioc2_handle_quirks(struct iommu_table *tbl, struct pci_dev
> *dev);
The patch was wordwrapped.
> + max_pfn = is_kdump_kernel() ? saved_max_pfn : end_pfn ;
> ...
> + return (elfcorehdr_addr != ELFCORE_ADDR_MAX) ? 1 : 0 ;
> ...
A couple of little coding-style errors there. checkpatch missed them.
next prev parent reply other threads:[~2008-07-17 23:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 20:40 [RFC] [Patch] calgary iommu: Use the first kernel's tce tables in kdump chandru
2007-10-09 21:06 ` Muli Ben-Yehuda
2007-10-10 5:30 ` Vivek Goyal
2007-10-14 5:41 ` Muli Ben-Yehuda
2007-10-15 6:29 ` Vivek Goyal
2007-12-24 5:15 ` Chandru
2008-03-10 13:20 ` Chandru
2008-03-10 16:09 ` Andrew Morton
2008-06-21 12:11 ` Chandru
2008-06-21 12:25 ` Mark Salyzyn
2008-06-23 19:29 ` Muli Ben-Yehuda
2008-07-15 8:45 ` Chandru
2008-07-15 10:52 ` Muli Ben-Yehuda
2008-07-17 23:14 ` Andrew Morton [this message]
2008-07-20 9:42 ` Muli Ben-Yehuda
2008-03-11 13:29 ` Vivek Goyal
2008-03-12 5:08 ` Chandru
2008-03-12 9:58 ` Muli Ben-Yehuda
2008-03-12 18:08 ` Vivek Goyal
2008-03-13 15:49 ` Muli Ben-Yehuda
2007-10-10 5:37 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717161414.c5a267f7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexisb@us.ibm.com \
--cc=apw@shadowen.org \
--cc=chandru@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).