Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediately unselectable.

From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediately unselectable.
Date: Sat, 26 Jul 2008 09:47:18 -0700	[thread overview]
Message-ID: <20080726094718.b617c1e7.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0807241135540.5289@localhost.localdomain>

On Sat, 26 Jul 2008 09:20:49 -0400 (EDT) Robert P. J. Day wrote:

> 
> Use "menuconfig" to allow all advanced partitions to be deselectable
> from the top-level FS menu.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Hi,

I like the idea, but it does have one problem.  Before this patch, if someone
disabled PARTITION_ADVANCED, the .config would still contain
CONFIG_MSDOS_PARTITION=y
but after this change, that config line is missing.  Not good.

> ---
> 
>  fs/Kconfig            |    4 ----
>  fs/partitions/Kconfig |    9 +++++++--
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 37db79a..f06241f 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -2143,11 +2143,7 @@ config 9P_FS
>  endif # NETWORK_FILESYSTEMS
> 
>  if BLOCK
> -menu "Partition Types"
> -
>  source "fs/partitions/Kconfig"
> -
> -endmenu
>  endif
> 
>  source "fs/nls/Kconfig"
> diff --git a/fs/partitions/Kconfig b/fs/partitions/Kconfig
> index cb5f0a3..4bb87d2 100644
> --- a/fs/partitions/Kconfig
> +++ b/fs/partitions/Kconfig
> @@ -1,8 +1,9 @@
>  #
>  # Partition configuration
>  #
> -config PARTITION_ADVANCED
> -	bool "Advanced partition selection"
> +
> +menuconfig PARTITION_ADVANCED
> +	bool "Advanced partition support"
>  	help
>  	  Say Y here if you would like to use hard disks under Linux which
>  	  were partitioned under an operating system running on a different
> @@ -14,6 +15,8 @@ config PARTITION_ADVANCED
> 
>  	  If unsure, say N.
> 
> +if PARTITION_ADVANCED
> +
>  config ACORN_PARTITION
>  	bool "Acorn partition support" if PARTITION_ADVANCED
>  	default y if ARCH_ACORN
> @@ -249,3 +252,5 @@ config SYSV68_PARTITION
>  	  partition table format used by Motorola Delta machines (using
>  	  sysv68).
>  	  Otherwise, say N.
> +
> +endif # PARTITION_ADVANCED

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/