From: Jack Steiner <steiner@sgi.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Nick Piggin <npiggin@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: GRU driver feedback
Date: Mon, 28 Jul 2008 12:44:37 -0500 [thread overview]
Message-ID: <20080728174437.GA29795@sgi.com> (raw)
In-Reply-To: <20080728173605.GB28480@sgi.com>
Whoops:
>
> - In gru_fault, I don't think you've validated the size of the vma, and it
> definitely seems like you haven't taken offset into the vma into account
> either. remap_pfn_range etc should probably validate the former because I'm
> sure this isn't the only driver that might get it wrong. The latter can't
> really be detected though. Please fix or make it more obviously correct (eg
> a comment).
ZZZ
s/ZZZ/fixed/
--- jack
next prev parent reply other threads:[~2008-07-28 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 14:12 GRU driver feedback Nick Piggin
2008-07-24 2:41 ` Nick Piggin
2008-07-24 3:26 ` Jack Steiner
2008-07-24 6:52 ` Nick Piggin
2008-07-28 17:36 ` Jack Steiner
2008-07-28 17:44 ` Jack Steiner [this message]
2008-07-29 2:00 ` Nick Piggin
2008-07-29 18:53 ` Robin Holt
2008-07-30 5:50 ` Nick Piggin
2008-07-31 7:14 ` Nick Piggin
2008-07-31 12:40 ` Jack Steiner
2008-08-01 12:11 ` Hugh Dickins
2008-08-01 20:09 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728174437.GA29795@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).