* [2.6 patch] SH_AP325RXA must select I2C
@ 2008-07-28 20:17 Adrian Bunk
2008-07-28 20:42 ` Paul Mundt
2008-07-28 22:38 ` Ben Dooks
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-07-28 20:17 UTC (permalink / raw)
To: lethal, Yusuke Goda, Magnus Damm; +Cc: linux-sh, linux-kernel
This patch fixes the following build error:
<-- snip -->
...
LD vmlinux
arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
setup.c:(.text+0x88): undefined reference to `i2c_transfer'
make[1]: *** [vmlinux] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
cdcb22706c51f0ae44946f4c3826cc3658960eba
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 7bfb0d2..6f77d0a 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -520,6 +520,7 @@ config SH_MIGOR
config SH_AP325RXA
bool "AP-325RXA"
depends on CPU_SUBTYPE_SH7723
+ select I2C
help
Renesas "AP-325RXA" support.
Compatible with ALGO SYSTEM CO.,LTD. "AP-320A"
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] SH_AP325RXA must select I2C
2008-07-28 20:17 [2.6 patch] SH_AP325RXA must select I2C Adrian Bunk
@ 2008-07-28 20:42 ` Paul Mundt
2008-07-28 22:38 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2008-07-28 20:42 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Yusuke Goda, Magnus Damm, linux-sh, linux-kernel
On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
The camera stuff should probably just be conditionalized in the platform
code instead.. Magnus, can you sort out the proper dependencies for this?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] SH_AP325RXA must select I2C
2008-07-28 20:17 [2.6 patch] SH_AP325RXA must select I2C Adrian Bunk
2008-07-28 20:42 ` Paul Mundt
@ 2008-07-28 22:38 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2008-07-28 22:38 UTC (permalink / raw)
To: Adrian Bunk; +Cc: lethal, Yusuke Goda, Magnus Damm, linux-sh, linux-kernel
On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
I suggest fixing the code or moving out to something that
depends on having I2C available.
> ---
> cdcb22706c51f0ae44946f4c3826cc3658960eba
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7bfb0d2..6f77d0a 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -520,6 +520,7 @@ config SH_MIGOR
> config SH_AP325RXA
> bool "AP-325RXA"
> depends on CPU_SUBTYPE_SH7723
> + select I2C
> help
> Renesas "AP-325RXA" support.
> Compatible with ALGO SYSTEM CO.,LTD. "AP-320A"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-28 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-28 20:17 [2.6 patch] SH_AP325RXA must select I2C Adrian Bunk
2008-07-28 20:42 ` Paul Mundt
2008-07-28 22:38 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).