From: Sam Ravnborg <sam@ravnborg.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: linux arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: kbuild now support arch/$ARCH/include - time for ARCHs to convert
Date: Wed, 30 Jul 2008 10:38:53 +0200 [thread overview]
Message-ID: <20080730083853.GB18366@uranus.ravnborg.org> (raw)
In-Reply-To: <48900EE4.8030606@snapgear.com>
On Wed, Jul 30, 2008 at 04:49:08PM +1000, Greg Ungerer wrote:
> Hi Sam,
>
> Sam Ravnborg wrote:
> >The traditional location of the arch specific Makefiles
> >has been at:
> >
> > include/asm-$ARCH
> >
> >But as suggested by several people over time and lately
> >by Linus in the following post:
> >http://kerneltrap.org/mailarchive/linux-kernel/2008/5/21/1903924
> >
> >is is suggested to move the arch specific files under arch/
> >and for the header files this is arch/$ARCH/include.
> >
> >So I have hacked up support for this in kbuild so
> >for the simpler cases a simple move of header files as
> >in:
> > git mv include/asm-$ARCH arch/$ARCH/include/asm
> >
> >is enough.
> >
> >If Linus will accept it then I think -rc1 is a perfect
> >time to do it as people has less stuff pending touching
> >the header files that are moved.
> >Validation is easy - does the usual configs build?
> >
> >For the archs that plays games with symlinks this is a
> >splendid opportunity to get rid af these.
> >The receipe is simple:
> >Use
> > KBUILD_CFLAGS += -Iarch/$ARCH/include/$CPU
> >
> >to select the CPU and then do a copy of the header files
> >like this:
> >
> > git mv include/asm-$ARCH/$CPU arch/$ARCH/include/$CPU/cpu
> >
> >Then the code can continue to use:
> >
> > #include <cpu/foo.h>
> >
> >I already converted sparc to use arch/sparc/include -
> >while I merged the header files for sparc and sparc64.
> >This change is already upstream.
> >
> >And for SH I posted a receipe which you can read here:
> >http://lkml.org/lkml/2008/7/28/83
> >
> >It is SH specific but anyway pretty generic.
> >
> >I am limited in time and resources at the moment but I
> >would be glad to help out as time permits should there
> >be any questions.
>
> I just tried moving the include/asm-m68knommu directory
> to arch/m68knommu/include/asm and it all worked fine.
> Clean compile first go :-) Nice. (As noted
> asm-offsets.h was still generated in incldue/asm-m68knommu
> afterwards though).
>
> So what is the status, should I prepare git/patch
> for Linus?
Yes please do so.
Then we can address m68k and fix the breakage that
the sparc changes introduced.
Sam
next prev parent reply other threads:[~2008-07-30 8:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 20:05 kbuild now support arch/$ARCH/include - time for ARCHs to convert Sam Ravnborg
2008-07-29 3:06 ` Kyle McMartin
2008-07-29 3:27 ` Sam Ravnborg
2008-07-29 14:21 ` Kyle McMartin
2008-08-09 2:50 ` Sam Ravnborg
2008-07-30 6:49 ` Greg Ungerer
2008-07-30 7:07 ` Arnd Bergmann
2008-07-30 8:52 ` Sam Ravnborg
2008-07-30 8:38 ` Sam Ravnborg [this message]
2008-08-01 6:03 ` Greg Ungerer
2008-08-03 20:16 ` Geert Uytterhoeven
2008-08-04 0:34 ` Greg Ungerer
2008-08-04 5:10 ` Sam Ravnborg
2008-08-04 14:35 ` Arnd Bergmann
2008-08-04 16:00 ` Geert Uytterhoeven
2008-08-04 16:45 ` Sam Ravnborg
2008-07-30 9:34 ` David Howells
2008-07-30 12:26 ` Geert Uytterhoeven
2008-07-31 3:23 ` Paul Mundt
2008-07-31 7:17 ` Geert Uytterhoeven
2008-07-31 11:26 ` Greg Ungerer
2008-07-31 19:47 ` Arnd Bergmann
2008-07-31 20:13 ` Sam Ravnborg
2008-08-01 7:35 ` Arnd Bergmann
2008-08-01 16:46 ` Sam Ravnborg
2008-07-31 18:23 ` Ralf Baechle
2008-07-31 20:14 ` Sam Ravnborg
2008-08-09 2:52 ` Sam Ravnborg
2008-08-09 3:09 ` Paul Mundt
2008-08-09 7:03 ` Sam Ravnborg
2008-08-09 7:20 ` Russell King
2008-08-09 11:13 ` Sam Ravnborg
2008-08-01 8:35 ` Martin Schwidefsky
2008-08-01 16:49 ` Sam Ravnborg
2008-08-05 4:18 ` Rusty Russell
2008-08-05 17:16 ` Geert Uytterhoeven
2008-08-05 20:45 ` Sam Ravnborg
2008-08-05 22:06 ` Russell King
2008-08-06 19:21 ` Russell King
2008-08-06 19:28 ` Sam Ravnborg
2008-08-06 19:51 ` Russell King
2008-08-06 19:27 ` Sam Ravnborg
2008-08-09 7:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730083853.GB18366@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gerg@snapgear.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).