From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759474AbYHAUJZ (ORCPT ); Fri, 1 Aug 2008 16:09:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756394AbYHAUJF (ORCPT ); Fri, 1 Aug 2008 16:09:05 -0400 Received: from relay1.sgi.com ([192.48.171.29]:58283 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753281AbYHAUJE (ORCPT ); Fri, 1 Aug 2008 16:09:04 -0400 Date: Fri, 1 Aug 2008 15:09:01 -0500 From: Jack Steiner To: Hugh Dickins Cc: Nick Piggin , Robin Holt , "Torvalds, Linus" , Nick Piggin , Andrew Morton , Linux Memory Management List , Linux Kernel Mailing List Subject: Re: GRU driver feedback Message-ID: <20080801200901.GA167958@sgi.com> References: <20080723141229.GB13247@wotan.suse.de> <20080729185315.GA14260@sgi.com> <200807301550.34500.nickpiggin@yahoo.com.au> <200807311714.05252.nickpiggin@yahoo.com.au> <20080731124039.GA27329@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 01, 2008 at 01:11:09PM +0100, Hugh Dickins wrote: > On Thu, 31 Jul 2008, Jack Steiner wrote: > > > > I'm collecting the fixes & additional comments to be added & will send > > them upstream later. > > One small thing to remove if you've not already noticed: > EXPORT_SYMBOL_GPL(follow_page) got added to mm/memory.c, > despite our realization that GRU cannot and now does not use it. > Thanks for catching this. I sent a patch upstream a few minutes ago to remove the export. --- jack