linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	airlied@linux.ie, Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch 2/2] reduce tlb/cache flush times of agpgart memory allocation
Date: Fri, 15 Aug 2008 16:43:12 +0200	[thread overview]
Message-ID: <20080815144312.GI12954@elte.hu> (raw)
In-Reply-To: <20080815074033.4817f876@infradead.org>


* Arjan van de Ven <arjan@infradead.org> wrote:

> On Fri, 15 Aug 2008 16:31:31 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
> 
> > 
> > * Shaohua Li <shaohua.li@intel.com> wrote:
> > 
> > > To reduce tlb/cache flush, makes agp memory allocation do one flush 
> > > after all pages in a region are changed to uc.
> > > 
> > > All agp drivers except agp-sgi uses agp_generic_alloc_page() for 
> > > .agp_alloc_page, so the patch should work for them. agp-sgi is only 
> > > for ia64, so not a problem too.
> > 
> > applied to tip/x86/pat - thanks!
> > 
> > I've Cc:-ed more PAT folks - any objections?
> > 
> 
> it really needs something else instead; it needs airlied's array 
> allocator otherwise you hit the second wall as well (the pat checks 
> per page)
> 
> in reality an array version of ioremap (or set_pages_X) is what is 
> needed

ok, agreed.

	Ingo

  reply	other threads:[~2008-08-15 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04  6:51 [patch 2/2] reduce tlb/cache flush times of agpgart memory allocation Shaohua Li
2008-08-15 14:31 ` Ingo Molnar
2008-08-15 14:40   ` Arjan van de Ven
2008-08-15 14:43     ` Ingo Molnar [this message]
2008-08-18  1:21     ` Li, Shaohua
2008-08-18  3:56       ` Arjan van de Ven
2008-08-18  6:19         ` Li, Shaohua
2008-08-18  8:03           ` Ingo Molnar
2008-08-18 17:18             ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080815144312.GI12954@elte.hu \
    --to=mingo@elte.hu \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=shaohua.li@intel.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).