From: David Fries <david@fries.net>
To: David Howells <dhowells@redhat.com>
Cc: sfr@canb.auug.org.au, jmorris@namei.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] Fix setting of PF_SUPERPRIV by __capable() [BROKEN]
Date: Sat, 16 Aug 2008 20:17:11 -0500 [thread overview]
Message-ID: <20080817011711.GA17528@spacedout.fries.net> (raw)
In-Reply-To: <20080814103728.13651.1528.stgit@warthog.procyon.org.uk>
The first two submissions this patch had parent for the argument, the third
one has child then parent and fails to compile with SECURITY disabled.
Please apply the following patch.
> +static inline int security_ptrace_traceme(struct task_struct *child)
> {
> - return cap_ptrace(parent, child, mode);
> + return cap_ptrace_traceme(parent);
> }
commit d8b5323c7c218d29da29eba35921d3b77fe403de
Author: David Fries <david@fries.net>
Date: Sat Aug 16 19:55:11 2008 -0500
security_ptrace_traceme error: 'parent' undeclared
s/child/parent/
Signed-off-by: David Fries <david@fries.net>
diff --git a/include/linux/security.h b/include/linux/security.h
index 2ee5ecf..80c4d00 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
return cap_ptrace_may_access(child, mode);
}
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
{
return cap_ptrace_traceme(parent);
}
next prev parent reply other threads:[~2008-08-17 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 10:37 [PATCH] Fix setting of PF_SUPERPRIV by __capable() David Howells
2008-08-17 1:17 ` David Fries [this message]
2008-08-18 12:52 ` [PATCH] Fix setting of PF_SUPERPRIV by __capable() [BROKEN] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817011711.GA17528@spacedout.fries.net \
--to=david@fries.net \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).