From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: hpa@zytor.com, tglx@linutronix.de, macro@linux-mips.org,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: one more apic merging preliminary series
Date: Sun, 17 Aug 2008 17:12:04 +0400 [thread overview]
Message-ID: <20080817131204.GB7418@lenovo> (raw)
In-Reply-To: <20080817124540.GF21434@elte.hu>
[Ingo Molnar - Sun, Aug 17, 2008 at 02:45:40PM +0200]
|
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
|
| > Please review - any comments are welcome!
| >
| > For now it's like code bloating - but it's just preliminary series to
| > make apic_*.c code more or less similar. And it's still a bit far from
| > being ready to be merged down.
|
| applied to tip/x86/apic - thanks Cyrill.
|
| Maciej's point about cleaning up the x2apic impact is very much true -
| i've Cc:-ed Suresh and Venki. Even if we wont truly use x2apic in 32-bit
| kernels, it's a piece of glue hardware that does not depend on which
| mode the CPU is in, so support for it should be bitsize agnostic. It
| will also obviously be good for test coverage, once x2apic capable hw
| will be more widespread.
|
| Ingo
|
Thanks Ingo. I found a bit obscure point in APIC 32bit code -
disable_esr variable to be clear. Code reading didn't answer
me the question "for what is needed". 82489DX doesn't have ESR
register indeed I presumed that the variable is needed to set
'absence-flag' of a such register on some platform but it seems
the only code snippet where we use this flag is 32bit lapic_setup_esr.
Moreover others 32bit writers don't check for this feature but
just writting to ESR register...
- Cyrill -
next prev parent reply other threads:[~2008-08-17 13:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 19:21 one more apic merging preliminary series Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 1/6] x86: apic - unify clear_local_APIC Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 2/6] x86: apic - unify lapic_resume Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 3/6] x86: apic - unify lapic_suspend Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 4/6] x86: apic - rearrange functions and comments Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 5/6] x86: apic - unify lapic_is_integrated Cyrill Gorcunov
2008-08-16 19:21 ` [PATCH 6/6] x86: apic - unify xapic_icr_read Cyrill Gorcunov
2008-08-16 19:52 ` [PATCH 2/6] x86: apic - unify lapic_resume Maciej W. Rozycki
2008-08-16 20:00 ` Arjan van de Ven
2008-08-16 20:12 ` Cyrill Gorcunov
2008-08-18 14:19 ` Maciej W. Rozycki
2008-08-18 14:39 ` Cyrill Gorcunov
2008-08-16 20:25 ` Maciej W. Rozycki
2008-08-16 20:05 ` Cyrill Gorcunov
2008-08-17 12:45 ` one more apic merging preliminary series Ingo Molnar
2008-08-17 13:12 ` Cyrill Gorcunov [this message]
2008-08-18 20:37 ` Suresh Siddha
2008-08-19 0:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817131204.GB7418@lenovo \
--to=gorcunov@gmail.com \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).