From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Jeff Garzik <jgarzik@redhat.com>, Ingo Molnar <mingo@elte.hu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2
Date: Tue, 19 Aug 2008 23:09:36 +0200 [thread overview]
Message-ID: <200808192309.37317.rjw@sisk.pl> (raw)
In-Reply-To: <48AB11E2.3040705@simon.arlott.org.uk>
On Tuesday, 19 of August 2008, Simon Arlott wrote:
> On 19/08/08 18:58, Rafael J. Wysocki wrote:
> > On Tuesday, 19 of August 2008, Simon Arlott wrote:
> >> On 18/08/08 23:08, Rafael J. Wysocki wrote:
> >> > On Monday, 18 of August 2008, Yinghai Lu wrote:
> >> >> On Mon, Aug 18, 2008 at 3:22 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> >>
> >> >> >> > > drivers/net/forcedeth.c | 8 +++++---
> >> >> >> > > 1 file changed, 5 insertions(+), 3 deletions(-)
> >> >> >> > >
> >> >> >> > > Index: linux-2.6/drivers/net/forcedeth.c
> >> >> >> > > ===================================================================
> >> >> >> > > --- linux-2.6.orig/drivers/net/forcedeth.c
> >> >> >> > > +++ linux-2.6/drivers/net/forcedeth.c
> >> >> >> > > @@ -5975,10 +5975,12 @@ static void nv_shutdown(struct pci_dev *
> >> >> >> > > if (netif_running(dev))
> >> >> >> > > nv_close(dev);
> >> >> >> > >
> >> >> >> > > - pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
> >> >> >> > > - pci_enable_wake(pdev, PCI_D3cold, np->wolenabled);
> >> >> >> > > pci_disable_device(pdev);
> >> >> >> > > - pci_set_power_state(pdev, PCI_D3hot);
> >> >> >> > > + if (system_state == SYSTEM_POWER_OFF) {
> >> >> >> > > + if (pci_enable_wake(pdev, PCI_D3cold, np->wolenabled))
> >> >> >> > > + pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
> >> >> >> > > + pci_set_power_state(pdev, PCI_D3hot);
> >> >> >> > > + }
> >> >> >> > > }
> >> >> >> > > #else
> >> >> >> > > #define nv_suspend NULL
> >> >> >> > >
> >> >> >> >
> >> >>
> >> >> > Does the last patch work for you BTW?
> >> >> >
> >> >>
> >> >> it works.
> >> >
> >> > OK, thanks for testing.
> >> >
> >> > I think we can use it as a quick fix for 2.6.27. Do you agree?
> >> >
> >> > Still, it would be helpful to verify if this is the same MSI issue reported by
> >> > Simon.
> >>
> >> I tried to test that patch but even without it standby/resume has stopped working:
> >
> > Which kernel is this?
>
> linus-2.6 a7f5aaf36ded825477c4d7167cc6eb1bcdc63191
>
> I've reverted to 2b12a4c524812fb3f6ee590a02e65b95c8c32229 where standby/resume still
> works and applied the above patch plus the pci_enable_device patch. It still doesn't
> work after resume if MSI is enabled.
My patch only affects the shutdown code path and is not related to
suspend/standby etc.
Could you identify the commit that broke standby/resume for you between
2b12a4c524812fb3f6ee590a02e65b95c8c32229 and
a7f5aaf36ded825477c4d7167cc6eb1bcdc63191 ? It looks like that should be
bisectable.
Thanks,
Rafael
next prev parent reply other threads:[~2008-08-19 21:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 6:25 [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2 Yinghai Lu
2008-08-17 13:02 ` Rafael J. Wysocki
2008-08-17 16:55 ` Rafael J. Wysocki
2008-08-17 19:16 ` Yinghai Lu
2008-08-17 19:29 ` Rafael J. Wysocki
2008-08-17 19:34 ` Rafael J. Wysocki
2008-08-17 20:58 ` Yinghai Lu
2008-08-17 21:47 ` Rafael J. Wysocki
2008-08-18 10:22 ` Rafael J. Wysocki
2008-08-18 21:50 ` Yinghai Lu
2008-08-18 22:08 ` Rafael J. Wysocki
2008-08-18 22:36 ` Yinghai Lu
2008-08-19 18:45 ` [PATCH] forcedeth: Fix kexec regression Rafael J. Wysocki
2008-08-19 20:37 ` Andrew Morton
2008-08-19 20:49 ` Rafael J. Wysocki
2008-08-20 7:01 ` Eric W. Biederman
2008-08-20 13:12 ` Rafael J. Wysocki
2008-08-18 22:37 ` [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2 Yinghai Lu
2008-08-18 22:42 ` Simon Arlott
2008-08-19 17:58 ` Rafael J. Wysocki
2008-08-19 18:33 ` Simon Arlott
2008-08-19 21:09 ` Rafael J. Wysocki [this message]
2008-08-30 19:39 ` Simon Arlott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808192309.37317.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=simon@fire.lp0.eu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).