From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbYIERwB (ORCPT ); Fri, 5 Sep 2008 13:52:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751167AbYIERvv (ORCPT ); Fri, 5 Sep 2008 13:51:51 -0400 Received: from one.firstfloor.org ([213.235.205.2]:56134 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbYIERvu (ORCPT ); Fri, 5 Sep 2008 13:51:50 -0400 Date: Fri, 5 Sep 2008 19:55:09 +0200 From: Andi Kleen To: Linus Torvalds Cc: David Sanders , linux-kernel@vger.kernel.org, Arjan van de Ven , Jan Beulich , Ingo Molnar , Thomas Gleixner , Andi Kleen Subject: Re: [BUG] x86 kenel won't boot under Virtual PC Message-ID: <20080905175509.GW18288@one.firstfloor.org> References: <200808311422.12525.linux@sandersweb.net> <20080831122751.72afafb5@infradead.org> <200809051138.20615.linux@sandersweb.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 05, 2008 at 09:30:14AM -0700, Linus Torvalds wrote: > > > On Fri, 5 Sep 2008, David Sanders wrote: > > > > The patch disables a optimization used in one place by commenting out some > > lines in nop.h. Please comment. > > Hmm.. I'm not a huge fan of the ASM_NOP mess, but you also disable it for > 64-bit x86 too. Heh -- I originally only added it because you're asked for it ... Yes going back to some simple generic nops and avoid all these problems would be a great thing. -Andi