linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org, "Hugh Dickens" <hugh@veritas.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Alan Jenkins" <alan-jenkins@tuffmail.co.uk>,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH 3 of 3] x86: clean up memory corruption check and add more kernel parameters
Date: Sun, 7 Sep 2008 11:11:12 +0200	[thread overview]
Message-ID: <20080907091112.GA5574@elte.hu> (raw)
In-Reply-To: <72081a970effa1a32861.1220777494@localhost>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> +	memory_corruption_check=0/1 [X86]

could you please add a second .config parameter as well:

  CONFIG_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y

which turns this parameter 1 without having to specify it on the boot 
command line. That way -tip's randconfig testing can check this on a 
couple of boxes and the WARN() will be detected automatically.

Also, i'd suggest to make the defaults of the scanning parameters be as 
widely enabled as reasonable - we want to see how much real problems 
this can catch.

> +config X86_CHECK_BIOS_CORRUPTION
> +        bool "Check for low memory corruption"
> +	default y

please make it default-disabled.

Looks good otherwise.

	Ingo

       reply	other threads:[~2008-09-07  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <patchbomb.1220777491@localhost>
     [not found] ` <72081a970effa1a32861.1220777494@localhost>
2008-09-07  9:11   ` Ingo Molnar [this message]
2008-09-07  9:37     ` [PATCH 4/3] x86: default corruption check to off, but put parameter default in Kconfig Jeremy Fitzhardinge
2008-09-07 15:40       ` Ingo Molnar
     [not found]         ` <20080907155030.GA24741@elte.hu>
2008-09-07 15:51           ` Ingo Molnar
2008-09-07 21:54             ` [PATCH 5/3] x86: fix compile error with corruption checking disabled Jeremy Fitzhardinge
2008-09-08 18:03               ` Ingo Molnar
2008-09-07 15:24 ` [PATCH 0 of 3] Low memory corruption detection and workaround Alan Jenkins
2008-09-08 11:23   ` Nick Piggin
2008-09-08 16:47     ` Jeremy Fitzhardinge
2008-09-08 17:01       ` Alan Cox
2008-09-08 18:44       ` Nick Piggin
2008-09-08 10:52 ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080907091112.GA5574@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=hpa@zytor.com \
    --cc=hugh@veritas.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).