linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chirag Jog <chirag@linux.vnet.ibm.com>
To: xavier droubay <xavier.droubay@gmail.com>
Cc: linux-rt-users@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] Convert tlbstate_lock spin_lock to raw_spin_lock
Date: Mon, 8 Sep 2008 13:07:32 +0530	[thread overview]
Message-ID: <20080908073732.GC5798@linux.vnet.ibm.com> (raw)
In-Reply-To: <2c6d8d720809071806i54e58093vf87bec5175d9b074@mail.gmail.com>

* xavier droubay <xavier.droubay@gmail.com> [2008-09-08 03:06:51]:

> Hello,
> 
> I experienced this "rtmutex.c:743" known bug with rt3 patch, using
> 
>  http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.26.3.tar.bz2
>  http://rt.et.redhat.com/download/patch-2.6.26.3-rt3.bz2
> 
> I compiled this kernel with the "make-kpkg" debian utility.
> 
> I first compiled this kernel with NO SMP, NO HIGHMEM, and partial ACPI
> (without fan, processor, ... modules). Attached file
> "config-2.6.26.3-rt3lowlty.frwr.gz".
> I didn't experience any problem with this kernel.
> 
> I then enabled SMP and HIGHMEM, and experienced  "rtmutex.c:743" BUG.
> Attached files
> "config-2.6.26.3-rt3rt-smp-hm.gz" and  "dmesg.gz" for some BUGGY message.
> 
> 
> I have seen somewhere on the archive, that some people still
> experienced problems with SMP.
> I guess no fix has been done from rt3 to rt7 patch. Can you confirm?
> 
> If so, which recent kernel should I use in order to get smp and rt
> running without problems?
> 
This simple patch should solve the above problem. Seeing the config, its
seems to be a 32bit box.


It convert tlbstate_lock spin_lock to raw_spin_lock.
Preemption has already been disabled, hence this change shouldn't
affect latency numbers.


Signed-Off-By: Chirag <chirag@linux.vnet.ibm.com>


diff --git a/arch/x86/kernel/tlb_32.c b/arch/x86/kernel/tlb_32.c
index 9bb2363..228849c 100644
--- a/arch/x86/kernel/tlb_32.c
+++ b/arch/x86/kernel/tlb_32.c
@@ -23,7 +23,7 @@ DEFINE_PER_CPU(struct tlb_state, cpu_tlbstate)
 static cpumask_t flush_cpumask;
 static struct mm_struct *flush_mm;
 static unsigned long flush_va;
-static DEFINE_SPINLOCK(tlbstate_lock);
+static DEFINE_RAW_SPINLOCK(tlbstate_lock);
 
 /*
  * We cannot call mmdrop() because we are in interrupt context,




       reply	other threads:[~2008-09-08  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2c6d8d720809071806i54e58093vf87bec5175d9b074@mail.gmail.com>
2008-09-08  7:37 ` Chirag Jog [this message]
2008-09-08 14:15   ` [PATCH] Convert tlbstate_lock spin_lock to raw_spin_lock Sujit Karataparambil
2008-09-08 15:04     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908073732.GC5798@linux.vnet.ibm.com \
    --to=chirag@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=xavier.droubay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).