From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbYIMPNG (ORCPT ); Sat, 13 Sep 2008 11:13:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751341AbYIMPMx (ORCPT ); Sat, 13 Sep 2008 11:12:53 -0400 Received: from mba.ocn.ne.jp ([122.1.235.107]:52104 "EHLO smtp.mba.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbYIMPMw (ORCPT ); Sat, 13 Sep 2008 11:12:52 -0400 Date: Sun, 14 Sep 2008 00:13:00 +0900 (JST) Message-Id: <20080914.001300.15242170.anemo@mba.ocn.ne.jp> To: david@fries.net Cc: paul.gortmaker@gmail.com, akpm@linux-foundation.org, p_gortmaker@yahoo.com, alan@lxorguk.ukuu.org.uk, jeff@garzik.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driver improvements From: Atsushi Nemoto In-Reply-To: <20080913144457.GE28469@spacedout.fries.net> References: <20080909025821.GA25019@spacedout.fries.net> <20080911.225503.59032738.anemo@mba.ocn.ne.jp> <20080913144457.GE28469@spacedout.fries.net> X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A B746 CA77 FE94 2874 D52F X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Sep 2008 09:44:57 -0500, David Fries wrote: > I reformatted your patch and added a comment. Does this work for you? > > diff --git a/drivers/net/ne.c b/drivers/net/ne.c ... > /* Update with any values found by probing. */ > - io[this_dev] = dev->base_addr; > - irq[this_dev] = dev->irq; > + if (0 <= this_dev && this_dev < MAX_NE_CARDS) { > + io[this_dev] = dev->base_addr; > + irq[this_dev] = dev->irq; > + } > return 0; > } For now rbtx49xx ne platform devices use -1 for pdev->id, but it may change. Please don't assume it. --- Atsushi Nemoto