From: Jarod Wilson <jwilson@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Janne Grunau <j@jannau.net>,
Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>,
Christoph Bartelmus <lirc@bartelmus.de>
Subject: Re: [PATCH 02/18] lirc serial port receiver/transmitter device driver
Date: Tue, 16 Sep 2008 00:08:43 -0400 [thread overview]
Message-ID: <200809160008.43218.jwilson@redhat.com> (raw)
In-Reply-To: <200809151420.32130.jwilson@redhat.com>
On Monday 15 September 2008 14:20:31 Jarod Wilson wrote:
> On Sunday 14 September 2008 23:55:38 Jarod Wilson wrote:
> > On Saturday 13 September 2008 04:41:33 Stefan Bauer wrote:
> > > On Saturday 13 September 2008 02:26, Janne Grunau wrote:
> > > > I hope I haven't broken anything with my lirc_dev changes. I doubt
> > > > I'll have a change to test it before monday.
> > >
> > > Unfortunately, you did. Commit ea74897 (port lirc to dynamic device
> > > numbers) broke things.
[...]
> So I've done a bit of work to fix up a few drivers so they properly check
> to see that lirc_register_driver() actually succeeded, and then
> accidentally stumbled onto the fix for the failure when merging some
> coverity-inspired patches from Erik Hovland. lirc_dev.c's lirc_cdev_add()
> function had an inverted kmalloc failure check. With that fixed, lirc_i2c
> appears to be behaving for me now, although I can't actually check to be
> 100% certain until I get home tonight.
[...]
> Fixes are in the git tree now for anyone else who wants to or is willing to
> test. Will verify myself tonight w/lirc_i2c and lirc_mceusb2 at a minimum.
Current git tree works for receiving IR signals via lirc_serial (tested by
Janne) and via lirc_mceusb2 (tested by me). Something is still slightly
haywire with lirc_i2c though. It registers fine, but IR signals simply aren't
making it to lircd. Probably unrelated to the dynamic device num changes,
looking into it.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2008-09-16 4:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 19:49 [PATCH 02/18] lirc serial port receiver/transmitter device driver Stefan Bauer
2008-09-12 16:24 ` Jarod Wilson
2008-09-13 0:26 ` Janne Grunau
2008-09-13 8:41 ` Stefan Bauer
2008-09-15 3:55 ` Jarod Wilson
2008-09-15 18:20 ` Jarod Wilson
2008-09-16 4:08 ` Jarod Wilson [this message]
2008-09-18 14:00 ` Jarod Wilson
2008-09-19 18:05 ` Stefan Bauer
2008-09-19 18:26 ` Janne Grunau
2008-09-19 18:53 ` Stefan Bauer
2008-09-19 19:24 ` Janne Grunau
2008-09-20 0:10 ` Janne Grunau
2008-09-26 19:42 ` Stefan Bauer
2008-09-19 18:54 ` Jarod Wilson
2008-09-19 19:12 ` Stefan Bauer
2008-09-13 7:09 ` Christoph Bartelmus
-- strict thread matches above, loose matches on Subject: below --
2008-09-09 4:05 [PATCH 0/18] linux infrared remote control drivers Jarod Wilson
2008-09-09 4:05 ` [PATCH 01/18] lirc core device driver infrastructure Jarod Wilson
2008-09-09 4:05 ` [PATCH 02/18] lirc serial port receiver/transmitter device driver Jarod Wilson
2008-09-09 16:14 ` Jonathan Corbet
2008-09-09 19:51 ` Stefan Lippers-Hollmann
2008-09-09 19:56 ` Jarod Wilson
2008-09-10 17:40 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809160008.43218.jwilson@redhat.com \
--to=jwilson@redhat.com \
--cc=j@jannau.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lirc@bartelmus.de \
--cc=stefan.bauer@cs.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).