Re: [PATCH 5/7] mmiotrace: handle TRACE_PRINT entries.

[Pekka Paalanen <pq@iki.fi>]

On Tue, 16 Sep 2008 16:11:20 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 16 Sep 2008, Pekka Paalanen wrote:
> 
> > From 6a458e250857907e16cb16799392fccbfd5f0f4a Mon Sep 17 00:00:00 2001
> > From: Pekka Paalanen <pq@iki.fi>
> > Date: Sun, 17 Aug 2008 18:15:13 +0300
> > Subject: [PATCH] mmiotrace: handle TRACE_PRINT entries.
> > 
> > Also make trace_seq_print_cont() non-static, and add a newline if the
> > seq buffer can't hold all data.
> > 
> > Signed-off-by: Pekka Paalanen <pq@iki.fi>
> > ---
> >  kernel/trace/trace.c           |   31 +++++++++++--------------------
> >  kernel/trace/trace.h           |   19 +++++++++++++++++++
> >  kernel/trace/trace_mmiotrace.c |   23 +++++++++++++++++++++++
> >  3 files changed, 53 insertions(+), 20 deletions(-)
> > 
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 406de9c..7e7154f 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
...
> > @@ -1517,12 +1500,16 @@ lat_print_timestamp(struct trace_seq *s, unsigned long long abs_usecs,
> >  
> >  static const char state_to_char[] = TASK_STATE_TO_CHAR_STR;
> >  
> > -static void
> > -trace_seq_print_cont(struct trace_seq *s, struct trace_iterator *iter)
> > +/*
> > + * The message is supposed to contain an ending newline.
> > + * If the printing stops prematurely, try to add a newline of our own.
> > + */
> > +void trace_seq_print_cont(struct trace_seq *s, struct trace_iterator *iter)
> >  {
> >  	struct trace_array *tr = iter->tr;
> >  	struct trace_array_cpu *data = tr->data[iter->cpu];
> >  	struct trace_entry *ent;
> > +	bool ok = true;
> 
> hmm, since when did the kernel have type bool?

Good question. It seems to be used a lot. :-)

commit 6e21828743247270d09a86756a0c11702500dbfb
Author: Richard Knutsson <ricknu-0@student.ltu.se>
Date:   Sat Sep 30 23:27:11 2006 -0700

    [PATCH] Generic boolean
    
    This patch defines:
    * a generic boolean-type, named 'bool'
    * aliases to 0 and 1, named 'false' and 'true'
    
    Removing colliding definitions of 'bool', 'false' and 'true'.
    
    Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

-- 
Pekka Paalanen
http://www.iki.fi/pq/