From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755978AbYJGBXZ (ORCPT ); Mon, 6 Oct 2008 21:23:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754279AbYJGBXR (ORCPT ); Mon, 6 Oct 2008 21:23:17 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:36491 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193AbYJGBXQ (ORCPT ); Mon, 6 Oct 2008 21:23:16 -0400 Date: Tue, 7 Oct 2008 10:22:48 +0900 From: KAMEZAWA Hiroyuki To: balbir@linux.vnet.ibm.com Cc: Andrew Morton , "linux-mm@kvack.org" , LKML , "nishimura@mxp.nes.nec.co.jp" Subject: Re: [PATCH 0/6] memcg update v6 (for review and discuss) Message-Id: <20081007102248.0f1694b8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <48EA4A3C.3030106@linux.vnet.ibm.com> References: <20081001165233.404c8b9c.kamezawa.hiroyu@jp.fujitsu.com> <20081002180229.5bb94727.kamezawa.hiroyu@jp.fujitsu.com> <48EA4A3C.3030106@linux.vnet.ibm.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Oct 2008 22:56:20 +0530 Balbir Singh wrote: > KAMEZAWA Hiroyuki wrote: > > On Wed, 1 Oct 2008 16:52:33 +0900 > > KAMEZAWA Hiroyuki wrote: > > > >> This series is update from v5. > >> > >> easy 4 patches are already posted as ready-to-go-series. > >> > >> This is need-more-discuss set. > >> > >> Includes following 6 patches. (reduced from v5). > >> The whole series are reordered. > >> > >> [1/6] make page_cgroup->flags to be atomic. > >> [2/6] allocate all page_cgroup at boot. > >> [3/6] rewrite charge path by charge/commit/cancel > >> [4/6] new force_empty and move_account > >> [5/6] lazy lru free > >> [6/6] lazy lru add. > >> > >> Patch [3/6] and [4/6] are totally rewritten. > >> Races in Patch [6/6] is fixed....I think. > >> > >> Patch [1-4] seems to be big but there is no complicated ops. > >> Patch [5-6] is more racy. Check-by-regression-test is necessary. > >> (Of course, I does some.) > >> > >> If ready-to-go-series goes, next is patch 1 and 2. > >> > > > > No terrible bugs until now on my test. > > > > My current idea for next week is following. > > (I may have to wait until the end of next merge window. If so, > > I'll wait and maintain this set.) > > > > - post ready-to-go set again. > > - post 1/6 and 2/6 as may-ready-to-go set. I don't chagnge order of these. > > - reflects comments for 3/6. > > patch 3/6 adds new functions. So, please tell me if you have better idea > > about new functions. > > - check logic for 4/6. > > - 5/6 and 6/6 may need some more comments in codes. > > - no new additional ones. > > Kamezawa-San, Andrew, > > I think patches 1 and 2 are ready to go. Andrew they remove the cgroup member > from struct page and will help reduce the overhead for distros that care about > 32 bit systems and also help with performance (in my runs so far). > > I would recommend pushing 1 and 2 right away to -mm followed by the other > performance improvements. Comments? > > I'll rebase ready-to-go 4 patches and this 1 and 2 onto the latest mmotm and send again. Thank you for review. Regards, -Kame > -- > Balbir > -- KAMEZAWA Hiroyuki