From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH 01/31] proc: switch /proc/loadavg to seq_file
Date: Tue, 21 Oct 2008 16:58:22 -0700 [thread overview]
Message-ID: <20081021165822.8d574935.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081017123958.GB22653@x200.localdomain>
On Fri, 17 Oct 2008 16:39:58 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> and move it to fs/proc/loadavg.c while I'm at it.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> fs/proc/Makefile | 2 +-
> fs/proc/loadavg.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> fs/proc/proc_misc.c | 26 --------------------------
While I think the patchset is a good thing, this is absolutely the worst
possible time to merge large code-motion changes into linux-next. We
need to maintain this stuff for more than two months, and everyone and
his puppy is altering those files. Today's linux-next already broke.
So I'd suggest that this all be deferred until the day before
2.6.29-rc1(!).
fs/proc/meminfo.c: In function 'meminfo_proc_show':
fs/proc/meminfo.c:90: error: 'NR_ACTIVE' undeclared (first use in this function)
fs/proc/meminfo.c:90: error: (Each undeclared identifier is reported only once
fs/proc/meminfo.c:90: error: for each function it appears in.)
fs/proc/meminfo.c:91: error: 'NR_INACTIVE' undeclared (first use in this function)
prev parent reply other threads:[~2008-10-21 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 12:39 [PATCH 01/31] proc: switch /proc/loadavg to seq_file Alexey Dobriyan
2008-10-21 23:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021165822.8d574935.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).