From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Theodore Tso <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, eugene@ibrix.com,
msnitzer@ibrix.com, akpm@linux-foundation.org
Subject: Re: [PATCH] Re: ext3: fix ext3_dx_readdir hash collision handling - Regression
Date: Sat, 25 Oct 2008 14:25:42 +0200 [thread overview]
Message-ID: <20081025122542.GA2354@gentoox2.trippelsdorf.de> (raw)
In-Reply-To: <20081025115631.GA17661@mit.edu>
On Sat, Oct 25, 2008 at 07:56:31AM -0400, Theodore Tso wrote:
>
> Unfortunately, the commit which which fixes the duplicated entries
> when there are hash collisions wasn't properly setting info->curr_hash
> and info->curr_minor_hash after going to the next node, which results
> the first entry being returned twice on the subsequent getdents()
> system call. What I don't understand was why I wasn't seeing this on
> a 32-bit kernel (maybe I screwed up my test environment; this problem
> should have occurred regardless of the 32-bit or 64-bit environment).
>
> In any case, if folks could test to see whether this patch fixes
> things, I'd appreciate it. (Patch for ext3 and ext4 follows).
>
> - Ted
Yep, your patch fixes the issue. Thank you Ted.
--
Markus
next prev parent reply other threads:[~2008-10-25 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 9:32 ext3: fix ext3_dx_readdir hash collision handling - Regression Markus Trippelsdorf
2008-10-23 3:28 ` Theodore Tso
2008-10-23 6:37 ` Markus Trippelsdorf
2008-10-24 0:01 ` Theodore Tso
[not found] ` <20081024042851.GA2360@gentoox2.trippelsdorf.de>
2008-10-24 10:41 ` Theodore Tso
2008-10-24 16:08 ` Linus Torvalds
2008-10-24 20:44 ` Theodore Tso
2008-10-25 11:56 ` [PATCH] " Theodore Tso
2008-10-25 12:25 ` Markus Trippelsdorf [this message]
2008-10-25 21:15 ` Linus Torvalds
2008-10-26 2:39 ` [GIT PULL] " Theodore Tso
2008-10-26 2:42 ` [PATCH 1/2] ext3: Fix duplicate entries returned from getdents() system call Theodore Ts'o
2008-10-26 2:42 ` [PATCH 2/2] ext4: " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081025122542.GA2354@gentoox2.trippelsdorf.de \
--to=markus@trippelsdorf.de \
--cc=akpm@linux-foundation.org \
--cc=eugene@ibrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msnitzer@ibrix.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).