* [PATCH] arm ide breakage
@ 2008-10-26 5:40 Al Viro
2008-10-27 18:38 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2008-10-26 5:40 UTC (permalink / raw)
To: Linus Torvalds; +Cc: bzolnier, rmk, linux-kernel
a) semicolon before the function body is a bad idea
b) it's const struct foo, not struct const foo
c) incidentally, it's ecard_remove_driver(), not ecard_unregister_driver()
d) compiling is occasionally useful.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/ide/icside.c b/drivers/ide/icside.c
index 76bdc9a..2d84801 100644
--- a/drivers/ide/icside.c
+++ b/drivers/ide/icside.c
@@ -690,9 +690,9 @@ static int __init icside_init(void)
return ecard_register_driver(&icside_driver);
}
-static void __exit icside_exit(void);
+static void __exit icside_exit(void)
{
- ecard_unregister_driver(&icside_driver);
+ ecard_remove_driver(&icside_driver);
}
MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
diff --git a/drivers/ide/rapide.c b/drivers/ide/rapide.c
index 78d27d9..d5003ca 100644
--- a/drivers/ide/rapide.c
+++ b/drivers/ide/rapide.c
@@ -11,7 +11,7 @@
#include <asm/ecard.h>
-static struct const ide_port_info rapide_port_info = {
+static const struct ide_port_info rapide_port_info = {
.host_flags = IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,
};
@@ -97,7 +97,7 @@ static int __init rapide_init(void)
static void __exit rapide_exit(void)
{
- ecard_unregister_driver(&rapide_driver);
+ ecard_remove_driver(&rapide_driver);
}
MODULE_LICENSE("GPL");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm ide breakage
2008-10-26 5:40 [PATCH] arm ide breakage Al Viro
@ 2008-10-27 18:38 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-10-27 18:38 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, rmk, linux-kernel
On Sunday 26 October 2008, Al Viro wrote:
> a) semicolon before the function body is a bad idea
> b) it's const struct foo, not struct const foo
> c) incidentally, it's ecard_remove_driver(), not ecard_unregister_driver()
> d) compiling is occasionally useful.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Thanks Al.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-27 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-26 5:40 [PATCH] arm ide breakage Al Viro
2008-10-27 18:38 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).