From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756080AbYJZRfq (ORCPT ); Sun, 26 Oct 2008 13:35:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755862AbYJZRf2 (ORCPT ); Sun, 26 Oct 2008 13:35:28 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:44052 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755451AbYJZRf1 (ORCPT ); Sun, 26 Oct 2008 13:35:27 -0400 Date: Sun, 26 Oct 2008 18:34:22 +0100 From: Jens Axboe To: Petr Vandrovec Cc: Elias Oltmanns , Paul Mundt , Alexander Beregalov , tj@kernel.org, torvalds@linux-foundation.org, LKML , linux-ide@vger.kernel.org Subject: Re: 2.6.27-rc1 (2fca5c): libata: kernel cant boot Message-ID: <20081026173421.GN22217@kernel.dk> References: <20081024070955.GN22217@kernel.dk> <20081024071329.GO22217@kernel.dk> <20081024071608.GA3879@linux-sh.org> <20081024072428.GP22217@kernel.dk> <873aimv0v8.fsf@denkblock.local> <20081024084818.GB22217@kernel.dk> <4903004D.2050904@vc.cvut.cz> <20081025184506.GM22217@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081025184506.GM22217@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 25 2008, Jens Axboe wrote: > On Sat, Oct 25 2008, Petr Vandrovec wrote: > > Jens Axboe wrote: > > >On Fri, Oct 24 2008, Elias Oltmanns wrote: > > >>Jens Axboe wrote: > > >>>From e598055dde1951c47c8b3522616f6ebff0ed9847 Mon Sep 17 00:00:00 2001 > > >>>From: Jens Axboe > > >>>Date: Fri, 24 Oct 2008 09:22:42 +0200 > > >>>Subject: [PATCH] libata: fix bug with non-ncq devices > > >>> > > >>>The recent commit 201f1b98822078c808b5e2d379a6ddbfc0a06ee1 to enable > > >>Wouldn't that be commit 2fca5ccf97d2c28bcfce44f5b07d85e74e3cd18e? > > > > > >Yes that is correct, the other commit is actually a private one in my > > >tree for other libata changes. Updated patch below, thanks for checking! > > > > > >From e598055dde1951c47c8b3522616f6ebff0ed9847 Mon Sep 17 00:00:00 2001 > > >From: Jens Axboe > > >Date: Fri, 24 Oct 2008 09:22:42 +0200 > > >Subject: [PATCH] libata: fix bug with non-ncq devices > > > > Hello, > > this fixes my DVD, but unfortunately NCQ devices connected to PMP are > > still dead - apparently as soon as mount() tries to do serious I/O on > > the drive. Backing out both post-2.6.28-rc1 fix as well as your > > original change brings storage back. I suspect that problem is that > > with PMP same tag cannot be (should not be? must not be?) used on > > multiple devices behind PMP - and before your change tags were allocated > > per-port, while now they are allocated per-device. > > That would indeed break, this requires allocating the tag map in the Totally untested, does this work? diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 4b95c43..0785c46 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1107,6 +1107,10 @@ static int ata_scsi_dev_config(struct scsi_device *sdev, depth = min(sdev->host->can_queue, ata_id_queue_depth(dev->id)); depth = min(ATA_MAX_QUEUE - 1, depth); + + if (dev->link->ap->pmp_link) + scsi_init_shared_tag_map(sdev->host, ATA_MAX_QUEUE - 1); + scsi_set_tag_type(sdev, MSG_SIMPLE_TAG); scsi_activate_tcq(sdev, depth); } -- Jens Axboe