From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: left over things in linux-next after 2.6.28-c1
Date: Tue, 28 Oct 2008 11:04:35 +0530 [thread overview]
Message-ID: <20081028053435.GA3473@in.ibm.com> (raw)
In-Reply-To: <20081025221015.GA32568@kroah.com>
On Sat, Oct 25, 2008 at 03:10:15PM -0700, Greg KH wrote:
> On Sat, Oct 25, 2008 at 11:52:45PM +0200, Sam Ravnborg wrote:
> > On Sat, Oct 25, 2008 at 02:16:51PM -0700, Greg KH wrote:
> > > On Sat, Oct 25, 2008 at 04:37:15PM +0200, Sam Ravnborg wrote:
> > > > > tests
> > > > >
> > > > > Ananth N Mavinakayanahalli (7):
> > > > > Add tests/ directory
> > > > > Move locking selftests to tests/
> > > > > Move rcutorture to tests/
> > > > > Move rtmutex tester to tests/
> > > > > Move lkdtm to tests/
> > > > > Move kprobes smoke tests to tests/
> > > > > Move backtrace selftests to tests/
> > > >
> > > > I have almost given up on this.
> > > > Three merge attemps failed for different reasons,
> > > > and I will not even have time for my maintainership
> > > > duties the next months.
> > > >
> > > > Anyone that can bring it forward?
> > >
> > > What are the reasons this is failing? Is it just moving different files
> > > around into the tests/ directory? Or is it new functionality here?
> > >
> > > If just moving stuff, is that really needed?
> >
> > The incentive was to have a common place to add small tests that
> > could be used to verify that the kernel works as expected.
> > From inkernel modules (like rcutorture) to small userspace
> > utilities such as something massaging the epoll interface or
> > similar.
> >
> > The above was just to get it started.
>
> Ok, that's great, but the current tree is just the in-kernel tests so
> far, right?
Right
> > Having a set of tests to run when introducing a new syscall
> > would make it much easier for an arch maintainer to verify
> > that the implemented syscall works as expected.
> >
> > And forcing the developer to use the interface from user-space
> > will hopefully catch a few issues earlier.
>
> I totally agree that this is a good thing to have.
>
> But I don't necessarily think that moving the in-kernel tests to this
> directory makes that much sense here, wouldn't the in-kernel tests work
> out better living next to the code they are testing, like they are right
> now? Or do you and others think that moving them would help things
> out?
I guess at the time, the consensus was to collate all such tests (except
the arch specific ones) to under tests/. But yes, there isn't too much
difference in it living next to the actual code itself. The other neat
thing this would do is to have one config sub-menu for all the in-kernel
tests, which can still be done with a new Kconfig in lib/ or something.
> And are there any proposed userspace tests in this tree right now?
No, it is currently limited to kernel code.
Ananth
next prev parent reply other threads:[~2008-10-28 5:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 13:50 linux-next: left over things in linux-next after 2.6.28-c1 Stephen Rothwell
2008-10-25 13:58 ` Al Viro
2008-10-25 14:37 ` Sam Ravnborg
2008-10-25 21:16 ` Greg KH
2008-10-25 21:52 ` Sam Ravnborg
2008-10-25 22:10 ` Greg KH
2008-10-28 5:34 ` Ananth N Mavinakayanahalli [this message]
2008-10-29 23:53 ` Greg KH
2008-10-25 21:20 ` Greg KH
2008-10-25 23:48 ` Randy Dunlap
2008-10-26 0:07 ` Randy Dunlap
2008-10-26 7:40 ` Stefan Richter
2008-10-26 8:17 ` Christoph Hellwig
2008-10-26 8:34 ` Stephen Rothwell
2008-10-26 8:39 ` Christoph Hellwig
2008-10-27 7:44 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028053435.GA3473@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).