From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Markus Rechberger" <mrechberger@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
em28xx <em28xx@mcentral.de>,
acano@fastmail.fm, "Andre Kelmanson" <akelmanson@gmail.com>,
"Bouwsma Barry" <freebeer.bouwsma@gmail.com>,
"Dan Kreiser" <kreiser@informatik.hu-berlin.de>,
"Frank Neuber" <fn@kernelport.de>,
"Jelle de Jong" <jelledejong@powercraft.nl>,
"John Stowers" <john.stowers.lists@gmail.com>,
"Lukas Kuna" <lukas.kuna@evkanet.net>,
"Stefan Vonolfen" <stefan.vonolfen@gmail.com>,
"Stephan Berberig" <s.berberig@arcor.de>,
"Thomas Giesecke" <thomas.giesecke@ibgmbh-naumburg.de>,
"Vitaly Wool" <vwool@ru.mvista.com>,
"Zhenyu Wang" <zhen78@gmail.com>,
v4l <video4linux-list@redhat.com>,
linux-dvb@linuxtv.org, greg@kroah.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/7] Adding empia base driver
Date: Sun, 2 Nov 2008 02:27:28 -0200 [thread overview]
Message-ID: <20081102022728.68e5e564@pedra.chehab.org> (raw)
In-Reply-To: <200811011459.17706.hverkuil@xs4all.nl>
On Sat, 1 Nov 2008 14:59:17 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> Hi Markus,
>
> As promised I've done a review of your empia driver and looked at what
> needs to be done to get it into the kernel.
>
> First of all, I've no doubt that your empia driver is better and
> supports more devices than the current em28xx driver. I also have no
> problem adding your driver separate from the current driver. It's been
> done before (certain networking drivers spring to mind) and while
> obviously not ideal I expect that the older em28xx driver can probably
> be removed after a year or something like that.
>
> In my opinion it's pretty much hopeless trying to convert the current
> em28xx driver into what you have. It's a huge amount of work that no
> one wants to do and (in this case) with very little benefit. Of course,
> Mauro has the final say in this.
>
Both upstream and the 4 duplicated drivers have similar functionality. Also,
the upstream driver is actively maintained. So, there's no sense on accepting
those duplicated drivers.
Also, just replacing one existing driver by a newer one will cause regressions
on some already fixed bugs and remove some improvements that the upstream driver
suffered.
If there's a bug or a lack of functionality on em28xx, cx25843, xc5000 or
tuner-xc2028, it is just a matter of submitting patches fixing those bugs or
adding newer features.
Cheers,
Mauro
next prev parent reply other threads:[~2008-11-02 4:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 21:14 [PATCH 1/7] Adding empia base driver Markus Rechberger
2008-10-22 22:09 ` Greg KH
2008-10-22 22:24 ` Markus Rechberger
2008-10-22 22:26 ` Markus Rechberger
2008-10-22 22:27 ` Greg KH
2008-10-22 22:35 ` Markus Rechberger
2008-10-22 22:49 ` Greg KH
2008-10-23 8:53 ` el es
2008-11-26 19:12 ` Aidan Thornton
2008-11-27 4:25 ` Markus Rechberger
2008-11-27 9:33 ` Pekka Enberg
2008-11-28 15:48 ` Devin Heitmueller
2008-11-28 20:09 ` Greg KH
2008-11-30 6:23 ` Markus Rechberger
2008-10-23 9:29 ` Alan Cox
2008-10-23 11:10 ` Markus Rechberger
2008-11-01 13:59 ` Hans Verkuil
2008-11-02 4:27 ` Mauro Carvalho Chehab [this message]
[not found] ` <a2aa6e3a0811072150t535e802cge3375a7b88ee6287@mail.gmail.com>
2008-11-08 10:15 ` Mauro Carvalho Chehab
2008-11-08 10:22 ` Markus Rechberger
2008-11-08 10:37 ` Mauro Carvalho Chehab
2008-11-08 10:42 ` Markus Rechberger
2008-11-08 10:46 ` Markus Rechberger
2008-11-08 10:56 ` Mauro Carvalho Chehab
2008-11-08 11:02 ` Markus Rechberger
2008-11-26 20:36 ` Aidan Thornton
[not found] <d9def9db0810221359h5118b8d2pd6d2b3f4f95496ce@mail.gmail.com>
[not found] ` <20081024153509.0f51d676@pedra.chehab.org>
2008-10-24 20:15 ` Markus Rechberger
2008-10-24 20:20 ` Markus Rechberger
2008-11-01 14:05 Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081102022728.68e5e564@pedra.chehab.org \
--to=mchehab@infradead.org \
--cc=acano@fastmail.fm \
--cc=akelmanson@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=em28xx@mcentral.de \
--cc=fn@kernelport.de \
--cc=freebeer.bouwsma@gmail.com \
--cc=greg@kroah.com \
--cc=hverkuil@xs4all.nl \
--cc=jelledejong@powercraft.nl \
--cc=john.stowers.lists@gmail.com \
--cc=kreiser@informatik.hu-berlin.de \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.kuna@evkanet.net \
--cc=mrechberger@gmail.com \
--cc=s.berberig@arcor.de \
--cc=stefan.vonolfen@gmail.com \
--cc=thomas.giesecke@ibgmbh-naumburg.de \
--cc=video4linux-list@redhat.com \
--cc=vwool@ru.mvista.com \
--cc=zhen78@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).