From: Dimitri Sivanich <sivanich@sgi.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and generic timer vector
Date: Fri, 21 Nov 2008 11:16:49 -0600 [thread overview]
Message-ID: <20081121171649.GB12370@sgi.com> (raw)
In-Reply-To: <49261276.10408@zytor.com>
On Thu, Nov 20, 2008 at 05:44:22PM -0800, H. Peter Anvin wrote:
> Ingo Molnar wrote:
> > * Dimitri Sivanich <sivanich@sgi.com> wrote:
> >
> >> The following patches provide a driver for synchronized RTC
> >> clocksource and clockevents for SGI systems, as well as a generic
> >> timer system interrupt.
> >>
> >> With these patches, a module can be installed that registers the
> >> system-wide synchronized RTC clocksource and timers as both a
> >> clocksource and clockevents device running in high resolution mode.
> >>
> >> [PATCH 1/2 v3] SGI RTC: add clocksource driver
> >> [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt
> >
> > Looks very clean and well-done to me.
> >
> > I had to take a good look at the rtc_timer_head->expires[] construct -
> > but i guess that's the best approach, as the max number of entries is
> > hard to judge at build time. (and we wont get any real limit
> > protection from gcc anyway)
> >
> > Thomas, any objections?
>
> I have *extremely* serious reservations about reserving even more
> hardware vectors for SGI only. This affects all systems, and quite
> frankly should not be necessary at all.
>
> The SGI UV people have pushed this at a number of points in the past,
> and we have told them to use an irqchip instead. This patch tries to
> allocate yet another reserved vector, instead.
I labeled the system vector as generic to indicate that this is available
to other platforms. See my other email to you for the reasons why I did
not use an irq instead.
prev parent reply other threads:[~2008-11-21 17:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 16:30 [PATCH 0/2 v2] SGI RTC: add clocksource/clockevent driver Dimitri Sivanich
2008-10-23 16:32 ` [PATCH 1/2 v2] SGI RTC: add clocksource driver Dimitri Sivanich
2008-10-23 16:34 ` [PATCH 2/2 v2] SGI RTC: add RTC system interrupt Dimitri Sivanich
2008-10-24 3:11 ` [PATCH 2/2 v3] " Dimitri Sivanich
2008-10-27 14:08 ` Ingo Molnar
2008-10-27 15:29 ` Dimitri Sivanich
2008-11-19 21:22 ` [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and generic timer vector Dimitri Sivanich
2008-11-19 21:23 ` [PATCH 1/2 v3] SGI RTC: add clocksource driver Dimitri Sivanich
2008-11-19 21:26 ` [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt Dimitri Sivanich
2008-11-20 23:12 ` Andrew Morton
2008-11-20 23:19 ` H. Peter Anvin
2008-11-21 17:15 ` Dimitri Sivanich
2008-11-21 18:26 ` H. Peter Anvin
2008-11-21 19:09 ` Yinghai Lu
2008-11-23 13:36 ` Ingo Molnar
2008-11-21 17:21 ` Dimitri Sivanich
2008-11-20 23:08 ` [PATCH 1/2 v3] SGI RTC: add clocksource driver Andrew Morton
2008-11-21 0:08 ` john stultz
2008-11-21 17:23 ` Dimitri Sivanich
2008-11-20 9:59 ` [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and generic timer vector Ingo Molnar
2008-11-21 1:44 ` H. Peter Anvin
2008-11-21 8:06 ` Ingo Molnar
2008-11-21 17:16 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121171649.GB12370@sgi.com \
--to=sivanich@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).