From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Vatsa <vatsa@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>,
Gregory Haskins <gregory.haskins@gmail.com>,
Pavel Machek <pavel@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v7 8/8] sched: idle_balance() does not call load_balance_newidle()
Date: Thu, 18 Dec 2008 23:42:52 +0530 [thread overview]
Message-ID: <20081218181252.GH26572@balbir.in.ibm.com> (raw)
In-Reply-To: <20081218175658.29812.62512.stgit@drishya.in.ibm.com>
* Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> [2008-12-18 23:26:59]:
> load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE
> is set at higher level domain (3-CPU) and not in low level domain
> (2-MC).
>
> pulled_task is initialised to -1 and checked for non-zero which
> is always true if the lowest level sched_domain does not have
> SD_BALANCE_NEWIDLE flag set.
>
> Trivial fix to initialise pulled_task to zero.
>
> This patch has been queued for 2.6.29
> http://lkml.org/lkml/2008/12/8/213
>
> Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
> ---
>
> kernel/sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index f82a7a0..e6a88bf 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -3773,7 +3773,7 @@ out_balanced:
> static void idle_balance(int this_cpu, struct rq *this_rq)
> {
> struct sched_domain *sd;
> - int pulled_task = -1;
> + int pulled_task = 0;
> unsigned long next_balance = jiffies + HZ;
> cpumask_t tmpmask;
>
Isn't this already in Ingo's patch queue?
--
Balbir
next prev parent reply other threads:[~2008-12-18 18:13 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 17:55 [PATCH v7 0/8] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 1/8] sched: convert BALANCE_FOR_xx_POWER to inline functions Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 2/8] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 3/8] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 4/8] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-12-18 18:12 ` Balbir Singh
2008-12-19 21:55 ` Andrew Morton
2008-12-19 22:19 ` Andrew Morton
2008-12-19 22:27 ` Ingo Molnar
2008-12-19 22:31 ` Ingo Molnar
2008-12-19 22:38 ` Andrew Morton
2008-12-19 22:54 ` Ingo Molnar
2008-12-20 4:36 ` Vaidyanathan Srinivasan
2008-12-20 4:44 ` Andrew Morton
2008-12-20 7:54 ` Ingo Molnar
2008-12-20 10:02 ` Vaidyanathan Srinivasan
2008-12-20 10:36 ` Vaidyanathan Srinivasan
2008-12-20 10:56 ` Vaidyanathan Srinivasan
2008-12-21 8:46 ` Ingo Molnar
2008-12-18 17:56 ` [PATCH v7 5/8] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-12-18 18:11 ` Balbir Singh
2008-12-18 17:56 ` [PATCH v7 6/8] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 7/8] sched: add SD_BALANCE_NEWIDLE at MC and CPU level for sched_mc>0 Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 8/8] sched: idle_balance() does not call load_balance_newidle() Vaidyanathan Srinivasan
2008-12-18 18:12 ` Balbir Singh [this message]
2008-12-18 20:17 ` Ingo Molnar
2008-12-18 20:19 ` [PATCH v7 0/8] Tunable sched_mc_power_savings=n Ingo Molnar
2008-12-18 20:31 ` Ingo Molnar
2008-12-19 8:29 ` Vaidyanathan Srinivasan
2008-12-19 8:24 ` Vaidyanathan Srinivasan
2008-12-19 13:34 ` Vaidyanathan Srinivasan
2008-12-29 23:43 ` MinChan Kim
2008-12-30 2:48 ` Balbir Singh
2008-12-30 6:21 ` Ingo Molnar
2008-12-30 6:44 ` Balbir Singh
2008-12-30 7:20 ` Ingo Molnar
2008-12-30 18:07 ` Vaidyanathan Srinivasan
2009-01-02 7:26 ` Vaidyanathan Srinivasan
2009-01-02 22:16 ` Ingo Molnar
2009-01-03 7:29 ` Mike Galbraith
2009-01-03 10:16 ` Vaidyanathan Srinivasan
2009-01-03 11:22 ` Mike Galbraith
2009-01-04 15:00 ` Mike Galbraith
2009-01-04 18:19 ` Vaidyanathan Srinivasan
2009-01-04 19:52 ` Mike Galbraith
2009-01-05 3:20 ` Vaidyanathan Srinivasan
2009-01-05 4:40 ` Mike Galbraith
2009-01-05 6:36 ` Mike Galbraith
2009-01-05 15:19 ` Mike Galbraith
2009-01-06 9:31 ` Mike Galbraith
2009-01-06 15:07 ` Vaidyanathan Srinivasan
2009-01-06 17:48 ` Mike Galbraith
2009-01-06 18:45 ` Balbir Singh
2009-01-07 8:59 ` Mike Galbraith
2009-01-07 11:26 ` Vaidyanathan Srinivasan
2009-01-07 14:36 ` Mike Galbraith
2009-01-07 15:35 ` Vaidyanathan Srinivasan
2009-01-08 8:06 ` Mike Galbraith
2009-01-08 17:46 ` Vaidyanathan Srinivasan
2009-01-09 6:00 ` Mike Galbraith
2009-01-06 14:54 ` Vaidyanathan Srinivasan
2008-12-30 17:31 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218181252.GH26572@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tconnors@astro.swin.edu.au \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).