From: Yan Li <elliot.li.tech@gmail.com>
To: gregkh@suse.de, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] enable CONFIG_USB_SUSPEND by default
Date: Fri, 2 Jan 2009 00:07:27 +0800 [thread overview]
Message-ID: <20090101160727.GA4390@thyme.bj.intel.com> (raw)
In-Reply-To: <20090101160343.GA4278@thyme.bj.intel.com>
Some USB devices need to be put into suspend mode before
unplugging. Without CONFIG_USB_SUSPEND we have no way to unplug them
safely.
Signed-off-by: Yan Li <elliot.li.tech@gmail.com>
---
drivers/usb/core/Kconfig | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index e1759d1..457ee9d 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -89,18 +89,20 @@ config USB_DYNAMIC_MINORS
config USB_SUSPEND
bool "USB selective suspend/resume and wakeup"
depends on USB && PM
+ default y
help
If you say Y here, you can use driver calls or the sysfs
"power/level" file to suspend or resume individual USB
- peripherals and to enable or disable autosuspend (see
- Documentation/usb/power-management.txt for more details).
+ peripherals and to enable or disable autosuspend. Some USB
+ devices need to be put into suspend mode before unplugging
+ (see Documentation/usb/power-management.txt for more details).
Also, USB "remote wakeup" signaling is supported, whereby some
USB devices (like keyboards and network adapters) can wake up
their parent hub. That wakeup cascades up the USB tree, and
could wake the system from states like suspend-to-RAM.
- If you are unsure about this, say N here.
+ If you are unsure about this, say Y here.
config USB_OTG
bool
--
1.5.6.5
--
Li, Yan
next prev parent reply other threads:[~2009-01-01 16:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 16:03 Enable CONFIG_USB_SUSPEND by default or some mobile HD can't be unplugged safely Yan Li
2009-01-01 16:07 ` Yan Li [this message]
2009-01-01 17:29 ` Alan Stern
2009-01-02 13:23 ` Yan Li
2009-01-01 17:32 ` Alexander E. Patrakov
2009-01-01 17:45 ` Alan Stern
2009-01-02 13:37 ` Yan Li
2009-01-02 13:46 ` Alexander E. Patrakov
2009-01-01 19:09 ` Robert Hancock
2009-01-02 9:56 ` Tino Keitel
2009-01-02 14:00 ` Yan Li
2009-01-02 14:08 ` Tino Keitel
2009-01-02 14:28 ` Yan Li
2009-01-02 16:04 ` Alan Stern
2009-01-03 2:33 ` Yan Li
2009-01-02 15:50 ` Mark Lord
2009-01-02 15:51 ` Mark Lord
2009-01-02 18:15 ` Tino Keitel
2009-01-03 2:24 ` Yan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101160727.GA4390@thyme.bj.intel.com \
--to=elliot.li.tech@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).