From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474AbZALQZG (ORCPT ); Mon, 12 Jan 2009 11:25:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753250AbZALQYx (ORCPT ); Mon, 12 Jan 2009 11:24:53 -0500 Received: from mail.vyatta.com ([76.74.103.46]:57016 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753009AbZALQYv convert rfc822-to-8bit (ORCPT ); Mon, 12 Jan 2009 11:24:51 -0500 Date: Mon, 12 Jan 2009 08:24:49 -0800 From: Stephen Hemminger To: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= Cc: Paul Gortmaker , netdev@vger.kernel.org, LKML Subject: Re: [PATCH] smc-ultra: get rid of "eth%d" message Message-ID: <20090112082449.5cfcd2cb@extreme> In-Reply-To: <4969CFF2.9020202@freemail.hu> References: <4969CFF2.9020202@freemail.hu> Organization: Vyatta X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Jan 2009 11:54:42 +0100 Németh Márton wrote: > From: Márton Németh > > Print out the dev->name only after register_netdev(). If the dev->name is > printk()ed out before calling register_netdev() the result will be "eth%d" > in the dmesg instead of "eth0". > > Signed-off-by: Márton Németh > --- > --- linux-2.6.28/drivers/net/smc-ultra.c.orig 2009-01-10 20:57:36.000000000 +0100 > +++ linux-2.6.28/drivers/net/smc-ultra.c 2009-01-10 20:59:48.000000000 +0100 > @@ -228,9 +228,6 @@ static int __init ultra_probe1(struct ne > for (i = 0; i < 6; i++) > dev->dev_addr[i] = inb(ioaddr + 8 + i); > > - printk("%s: %s at %#3x, %s", dev->name, model_name, > - ioaddr, print_mac(mac, dev->dev_addr)); > - > /* Switch from the station address to the alternate register set and > read the useful registers there. */ > outb(0x80 | reg4, ioaddr + 4); > @@ -253,8 +250,10 @@ static int __init ultra_probe1(struct ne > irq = irqmap[((irqreg & 0x40) >> 4) + ((irqreg & 0x0c) >> 2)]; > > if (irq == 0) { > - printk(", failed to detect IRQ line.\n"); > - retval = -EAGAIN; > + printk(KERN_ERR "%s at %#3x, %s, " > + "failed to detect IRQ line.\n", model_name, > + ioaddr, print_mac(mac, dev->dev_addr)); > + retval = -EAGAIN; > goto out; > } > dev->irq = irq; > @@ -280,22 +279,19 @@ static int __init ultra_probe1(struct ne > > ei_status.mem = ioremap(dev->mem_start, (ei_status.stop_page - START_PG)*256); > if (!ei_status.mem) { > - printk(", failed to ioremap.\n"); > - retval = -ENOMEM; > + printk(KERN_ERR "%s at %#3x, %s, failed to ioremap.\n", > + model_name, ioaddr, print_mac(mac, dev->dev_addr)); Use dev_err() instead, it gives useful PCI information. > + retval = -ENOMEM; > goto out; > } > > dev->mem_end = dev->mem_start + (ei_status.stop_page - START_PG)*256; > > if (piomode) { > - printk(",%s IRQ %d programmed-I/O mode.\n", > - eeprom_irq ? "EEPROM" : "assigned ", dev->irq); > ei_status.block_input = &ultra_pio_input; > ei_status.block_output = &ultra_pio_output; > ei_status.get_8390_hdr = &ultra_pio_get_hdr; > } else { > - printk(",%s IRQ %d memory %#lx-%#lx.\n", eeprom_irq ? "" : "assigned ", > - dev->irq, dev->mem_start, dev->mem_end-1); > ei_status.block_input = &ultra_block_input; > ei_status.block_output = &ultra_block_output; > ei_status.get_8390_hdr = &ultra_get_8390_hdr; > @@ -311,6 +307,21 @@ static int __init ultra_probe1(struct ne > retval = register_netdev(dev); > if (retval) > goto out; > + > + if (piomode) { > + printk(KERN_INFO "%s: %s at %#3x, %s," > + "%s IRQ %d programmed-I/O mode.\n", > + dev->name, model_name, ioaddr, > + print_mac(mac, dev->dev_addr), > + eeprom_irq ? " EEPROM" : " assigned", dev->irq); > + } else { > + printk(KERN_INFO "%s: %s at %#3x, %s," > + "%s IRQ %d memory %#lx-%#lx.\n", > + dev->name, model_name, ioaddr, > + print_mac(mac, dev->dev_addr), > + eeprom_irq ? "" : " assigned", > + dev->irq, dev->mem_start, dev->mem_end-1); > + } > dev_info?