From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753295AbZALJDi (ORCPT ); Mon, 12 Jan 2009 04:03:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751902AbZALJDW (ORCPT ); Mon, 12 Jan 2009 04:03:22 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:33783 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbZALJDU (ORCPT ); Mon, 12 Jan 2009 04:03:20 -0500 Date: Mon, 12 Jan 2009 10:03:07 +0100 From: Ingo Molnar To: Mandeep Singh Baines Cc: linux-kernel@vger.kernel.org, rientjes@google.com, mbligh@google.com, thockin@google.com Subject: Re: [PATCH v2] softlockup: decouple hung tasks check from softlockup detection Message-ID: <20090112090307.GC26750@elte.hu> References: <20090112065213.GA19795@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090112065213.GA19795@google.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mandeep Singh Baines wrote: > Decoupling allows: > > * hung tasks check to happen at very low priority > * hung tasks check and softlockup to be enabled/disabled independently > at compile and/or run-time > * individual panic settings to be enabled disabled independently > at compile and/or run-time > * softlockup threshold to be reduced without increasing hung tasks > poll frequency (hung task check is expensive relative to softlock watchdog) > * hung task check to be zero over-head when disabled at run-time > --- > include/linux/sched.h | 14 +++++-- > kernel/Makefile | 1 + > kernel/softlockup.c | 102 ------------------------------------------------- > kernel/sysctl.c | 15 +++++++- > lib/Kconfig.debug | 38 ++++++++++++++++++ > 5 files changed, 63 insertions(+), 107 deletions(-) Looks good in principle, but i suspect your patch submission should include the new kernel/hung_task.c file too ;-) Ingo