From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757913AbZANAwI (ORCPT ); Tue, 13 Jan 2009 19:52:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754524AbZANAvw (ORCPT ); Tue, 13 Jan 2009 19:51:52 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:38700 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754412AbZANAvv (ORCPT ); Tue, 13 Jan 2009 19:51:51 -0500 Date: Wed, 14 Jan 2009 11:51:10 +1100 From: Herbert Xu To: David Miller Cc: zbr@ioremap.net, dada1@cosmosbay.com, w@1wt.eu, ben@zeus.com, jarkao2@gmail.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jens.axboe@oracle.com Subject: Re: [PATCH] tcp: splice as many packets as possible at once Message-ID: <20090114005110.GA6814@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090113.161625.111759506.davem@davemloft.net> Organization: Core X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > > I wish there were some way we could make this code grab and release a > reference to the SKB data area (I mean skb_shinfo(skb)->dataref) to > accomplish it's goals. We can probably do that for spliced data that end up going to the networking stack again. However, as splice is generic the data may be headed to a destination other than the network stack. In that case to make dataref work we'd need some mechanism that allows non-network entities to get/drop this ref count. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt