From: Sam Ravnborg <sam@ravnborg.org>
To: Dave Airlie <airlied@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@linux.ie>,
dri-devel@lists.sf.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [git pull] drm-fixes
Date: Mon, 26 Jan 2009 22:52:35 +0100 [thread overview]
Message-ID: <20090126215235.GA10484@uranus.ravnborg.org> (raw)
In-Reply-To: <21d7e9970901261344v2909cc61m42f32f2a434df0c4@mail.gmail.com>
>
> Well I'm not 100% sure what happened for this patch, I suspect,
> jbarnes sent patch a week
> or two ago, it misapplied against the tree I had currently when
> applied with git-am, it didn't work so I hand
> applied the patch with patch and then did git commit
> --author="jbarnes" as he did write it, I just munged it.
>
> Now I'm unsure how I should best handle this, in a world where I can
> devote a lot more time to
> maintaining this, I would sent Jesse a mail saying, rebase, he'd reply
> with a rebase and I'd apply it,
> however I generally find it easier to just fix this stuff up on the
> run as its synchronous. Should
> I be specifying a date somewhere in the commit message?
My simple way to deal with this is to:
0) save the mail
1) fix subject and changelog and add my Signed-off-by:
2) apply the patch somehow
3) replace the origianl patch in the (saved) mail
4) git reset --hard (or patch -p1 -R < saved-mail)
5) git am <saved mail>
There must be easier ways to do so I think.
But the above is what my fingers know to do so I do it
routinely.
Sam
next prev parent reply other threads:[~2009-01-26 21:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 4:46 [git pull] drm-fixes Dave Airlie
2009-01-26 18:23 ` Linus Torvalds
2009-01-26 21:44 ` Dave Airlie
2009-01-26 21:52 ` Sam Ravnborg [this message]
2009-01-26 22:08 ` Linus Torvalds
2009-01-26 22:19 ` Linus Torvalds
2009-01-26 22:38 ` Johannes Weiner
2009-02-23 0:15 Dave Airlie
2009-02-25 4:56 Dave Airlie
2009-08-04 3:45 Dave Airlie
2009-08-05 2:11 Dave Airlie
2009-10-28 1:32 Dave Airlie
2010-09-02 1:37 Dave Airlie
2011-01-24 23:19 Dave Airlie
2011-06-17 0:38 Dave Airlie
2011-12-24 17:43 Dave Airlie
2012-06-17 7:42 Dave Airlie
2012-06-17 19:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126215235.GA10484@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sf.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).