From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757933AbZBBStU (ORCPT ); Mon, 2 Feb 2009 13:49:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754663AbZBBStK (ORCPT ); Mon, 2 Feb 2009 13:49:10 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:51760 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754245AbZBBStJ (ORCPT ); Mon, 2 Feb 2009 13:49:09 -0500 Date: Mon, 2 Feb 2009 19:48:44 +0100 From: Ingo Molnar To: Mike Frysinger Cc: Jaswinder Singh Rajput , Linus Torvalds , Sam Ravnborg , Andrew Morton , Russell King - ARM Linux , hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML Subject: Re: [git pull -tip] headers_check fixes for other architectures Message-ID: <20090202184844.GA9650@elte.hu> References: <1233385816.17794.16.camel@localhost.localdomain> <20090131164410.GA11189@elte.hu> <1233469811.5846.14.camel@localhost.localdomain> <20090201103936.GA30157@elte.hu> <20090201164915.GA29264@elte.hu> <8bd0f97a0902020911h6cc45be0m8b2affb5a531d160@mail.gmail.com> <20090202180811.GC1394@elte.hu> <8bd0f97a0902021029xa07a4d2n9779137a7d2bb9cd@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bd0f97a0902021029xa07a4d2n9779137a7d2bb9cd@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Frysinger wrote: > On Mon, Feb 2, 2009 at 13:08, Ingo Molnar wrote: > > * Mike Frysinger wrote: > >> On Sun, Feb 1, 2009 at 11:49, Ingo Molnar wrote: > >> > These are the remaining ones on x86: > >> > > >> > 17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h > >> > 12 /dev/shm/tip/usr/include/linux/soundcard.h > >> > 6 /dev/shm/tip/usr/include/asm/setup.h > >> > 3 /dev/shm/tip/usr/include/linux/nubus.h > >> > 2 /dev/shm/tip/usr/include/linux/in6.h > >> > 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h > >> > 1 /dev/shm/tip/usr/include/linux/socket.h > >> > 1 /dev/shm/tip/usr/include/linux/coda_psdev.h > >> > 1 /dev/shm/tip/usr/include/asm/prctl.h > >> > > >> > They are all of the "extern's make no sense in userspace" type. What was > >> > the verdict, are they worth touching, or should we turn off this warning > >> > in 'make headers_check'? > >> > >> the warning wouldnt have been added if it didnt make sense ... like it > >> says, prototypes for kernel functions make no sense in userspace headers > > > > the existence of a warning does not justify it. For example the CONFIG_* > > warnings were deemed largely bogus and were removed. > > kernel function prototypes make no sense in userspace, especially > considering how much effort goes into avoiding namespace pollution. i agree, i only addressed this rather incorrect statement: "the warning wouldnt have been added if it didnt make sense ..." Ingo