From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757463AbZBFITV (ORCPT ); Fri, 6 Feb 2009 03:19:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753454AbZBFITH (ORCPT ); Fri, 6 Feb 2009 03:19:07 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:41776 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754326AbZBFITF (ORCPT ); Fri, 6 Feb 2009 03:19:05 -0500 From: KOSAKI Motohiro To: Jaswinder Singh Rajput Subject: [linux-next][PATCH] revert headers_check fix: ia64, fpu.h Cc: kosaki.motohiro@jp.fujitsu.com, Ingo Molnar , Linus Torvalds , Sam Ravnborg , Andrew Morton , Russell King - ARM Linux , hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML , linux-next , linux-ia64 , Tony Luck In-Reply-To: <1233385816.17794.16.camel@localhost.localdomain> References: <1233385816.17794.16.camel@localhost.localdomain> Message-Id: <20090206164546.6291.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Fri, 6 Feb 2009 17:19:00 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/arch/ia64/include/asm/fpu.h b/arch/ia64/include/asm/fpu.h > index 3859558..b6395ad 100644 > --- a/arch/ia64/include/asm/fpu.h > +++ b/arch/ia64/include/asm/fpu.h > @@ -6,7 +6,7 @@ > * David Mosberger-Tang > */ > > -#include > +#include this change break ia64 build perfectly. this patch seems don't tested at all. Ingo, I hope you ask patch author how to test posted patch ;-) == Subject: [PATCH] revert headers_check fix: ia64, fpu.h commit fa9ea6c7abd94482ecd84e130676b6a1b3e61c2c break ia64 build perfectly. it because ia64 has following include file dependency. entry.S -> asm/processor.h -> asm/ptrace.h -> asm/fpu.h Then, above commit introduce below dependency. entry.S -> asm/processor.h -> asm/ptrace.h -> asm/fpu.h -> linux/types.h -> linux/posix_types.h -> linux/stddef.h Then, assembler can't intepret following statement in stddef.h enum { false = 0, true = 1 }; Therefore, >100 line tons error was outputed. Signed-off-by: KOSAKI Motohiro Cc: Jaswinder Singh Rajput Cc: Andrew Morton Cc: linux-next Cc: linux-ia64 Cc: Tony Luck --- arch/ia64/include/asm/fpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/arch/ia64/include/asm/fpu.h =================================================================== --- a/arch/ia64/include/asm/fpu.h +++ b/arch/ia64/include/asm/fpu.h @@ -6,7 +6,7 @@ * David Mosberger-Tang */ -#include +#include /* floating point status register: */ #define FPSR_TRAP_VD (1 << 0) /* invalid op trap disabled */